fix(codex): drop transient rs_tmp reasoning replay state - #11038
Closed
kpadilha wants to merge 1 commit into
Closed
Conversation
19 tasks
kpadilha
force-pushed
the
fix/codex-rs-tmp-replay-source
branch
2 times, most recently
from
May 13, 2026 14:58
f31172b to
a138d32
Compare
kpadilha
force-pushed
the
fix/codex-rs-tmp-replay-source
branch
from
May 25, 2026 15:37
a138d32 to
a7c6e2e
Compare
teknium1
added a commit
that referenced
this pull request
May 27, 2026
Contributor
|
Salvaged onto current main via #33146 (merged as b1a46b3). Your authorship is preserved in |
mathias3
pushed a commit
to mathias3/hermes-agent
that referenced
this pull request
May 28, 2026
Bryce-huang
pushed a commit
to wbkunlun/hermes-agent
that referenced
this pull request
May 29, 2026
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 25, 2026
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
donbowman
pushed a commit
to donbowman/hermes-agent
that referenced
this pull request
Jul 13, 2026
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops Hermes from persisting transient Codex reasoning replay items whose ids use the
rs_tmp_*prefix.These temporary blobs later contaminate replay state and can surface as
invalid_encrypted_contentfailures. Hermes already has runtime recovery in another patch; this PR addresses the contamination at the source by avoiding persistence of the transient replay state in the first place.Related Issue
No tracked issue. This PR complements existing Codex replay recovery work by preventing the bad transient state from being written.
Type of Change
Changes Made
_normalize_codex_response()to drop transientrs_tmp_*reasoning replay items.incompletehandling for reasoning-only responses even when the transient replay blob is skipped.rs_*reasoning replay state intact.tests/run_agent/test_run_agent_codex_responses.pyfor:rs_*preservationHow to Test
python -m pytest -o addopts='' tests/run_agent/test_run_agent_codex_responses.py -q47 passedlocally when validated).rs_tmp_*items are dropped while stablers_*items are preserved.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs