Skip to content

fix(cli): validate plugin toolsets against persisted plugin-key cache #109938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iskandarsulaili wants to merge 1 commit into from
Closed

fix(cli): validate plugin toolsets against persisted plugin-key cache #109938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2749,7 +2749,17 @@ def _init_toolsets(self, toolsets):
if toolsets and "all" not in toolsets and "*" not in toolsets:
# MCP server names only resolve after discover_mcp_tools runs; skip them here.
mcp_names = set((CLI_CONFIG.get("mcp_servers") or {}).keys())
invalid = [t for t in toolsets if not validate_toolset(t) and t not in mcp_names]
# Plugin toolsets register in a background discovery thread that may not have
# joined yet, so validate against the persisted plugin toolset-key cache too —
# otherwise every enabled plugin toolset is falsely flagged "unknown" (the
# tools themselves still load; this is pure warning noise).
try:
from hermes_cli.plugins import get_plugin_toolset_keys_nowait
plugin_ts_keys = get_plugin_toolset_keys_nowait()
except Exception:
plugin_ts_keys = set()
invalid = [t for t in toolsets if not validate_toolset(t)
and t not in mcp_names and t not in plugin_ts_keys]
if invalid:
self._console_print(f"[bold red]Warning: Unknown toolsets: {', '.join(invalid)}[/]")

Expand Down