Conversation
This was referenced Sep 13, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes sessions statsand other display-only session subcommands opened a writable SessionDB even though they only read the store. On a live WAL database that transient writer can participate in close-time WAL cleanup and reproduce the reported deleted-sidecar generation. This change routes non-mutating session commands throughSessionDB(read_only=True)while leaving mutating commands on the writable open path.Changes
hermes_cli/sessions_cmd.py: adds a read-only handler allowlist for
list,pinned, andstats, and passesread_only=Truewhen dispatching those commands.tests/hermes_cli/test_sessions_error_exit_codes.py: adds regression coverage that
statsopens read-only and a mutating command still opens a writer.How to Test
python -m pytest tests/hermes_cli/test_sessions_error_exit_codes.py -q
✅ 5/5 passed
ruff check hermes_cli/sessions_cmd.py tests/hermes_cli/test_sessions_error_exit_codes.py
✅ passed
python scripts/check-windows-footguns.py hermes_cli/sessions_cmd.py tests/hermes_cli/test_sessions_error_exit_codes.py
✅ passed
Notes
scripts/run_tests.sh tests/hermes_cli/test_sessions_error_exit_codes.py -q was attempted in the Termux sandbox and failed before collection with PermissionError(13, 'Permission denied'); direct pytest passed.
ruff format --check was not applied because these legacy files would be broadly reformatted unrelated to this fix.
Checklist
Risk & Impact
Low. The change only selects read-only SessionDB opens for display-only session commands and keeps mutating commands writable.
Type: Bug fix
Closes: #109687