hermes doctor tells image_gen users to configure a provider, not "system dependency not met" (#9516, salvage #9548) - #109136
Merged
Merged
Conversation
…dependency not met" image_gen has several setup paths (FAL_KEY, managed Nous image generation, plugin providers) so it declares no single `requires_env`; doctor's generic branch then labelled a missing credential a "system dependency not met" and left it out of the "run hermes setup" summary. A small per-toolset setup-hint table: image_gen gets an actionable line pointing at `hermes tools`, counts toward the setup summary, and toolsets with a genuine system dependency (homeassistant) keep the old wording. Port of PR #9548 by @skyc1e onto `hermes_cli/doctor_tools.py`. Fixes #9516
Windows-footgun ratchet for the file touched by this fix (no behaviour change).
૮ >ﻌ< ა ci reviewran on 34b8d29 — fix(doctor): image_gen hint covers a selected provider with
|
This was referenced Sep 12, 2026
… key or SDK Review finding on #109136: "no provider configured" was wrong when a provider IS selected but its SDK/key is absent. Word it as unavailable + where to look.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hermes doctorreportsimage_gen (no image generation provider configured — set one up with 'hermes tools')and counts it toward the "run hermes setup" summary.image_genhas several setup paths (FAL_KEY, managed Nous image generation, plugin providers) so it declares no singlerequires_env; doctor's generic branch mislabelled a missing credential as a system dependency and left it out of the summary.hermes_cli/doctor_tools.py; toolsets with a genuine system dependency (homeassistant) keep the old wording.Live repro: test
test_image_gen_without_provider_reports_setup_hint_not_system_dependencyred onorigin/main(⚠ image_gen (system dependency not met)), green here.Salvage of #9548 by @skyc1e onto
doctor_tools.py; #9540 / #9558 / #9715 / #9757 were narrower variants.Fixes #9516 (reported by @404Dealer).
Update — review fix
Hint reworded to "image generation unavailable — check the provider selection and its key or SDK with 'hermes tools'" so it is also accurate when a provider is selected but its SDK/key is missing. Commit 34b8d29.
Infographic