fix(desktop): rearm voice conversation after stop (#108301) - #108407
Tranquil-Flow wants to merge 1 commit into
Conversation
Related: #81176 (open since 2026-08-07) removes the same |
|
Comment assumes head CHECK — Desktop voice-conversation re-arm after Stop (#108301)
CHECK (desk / competitors)
One-click close / ordering
Landing-evidence
|
1 similar comment
|
Comment assumes head CHECK — Desktop voice-conversation re-arm after Stop (#108301)
CHECK (desk / competitors)
One-click close / ordering
Landing-evidence
|
What
Fixes #108301.
Desktop voice conversation mode now treats Stop/Esc during read-aloud as a reply-only interruption, not as the end of hands-free mode:
Why
The previous
settleAfterSpeech()path detected an external stop via the voice playback sequence and then skippedpendingStartRef.current = true. The UI remained in voice-conversation mode, but the mic never reopened. It also left the stopped pending response available to future playback consumers.Verification
Run from
apps/desktopafter rebasing onto currentupstream/main:npx vitest run --project ui src/app/chat/composer/hooks/use-voice-conversation-rearm.test.tsx src/app/chat/composer/hooks/use-voice-conversation.test.tsx --reporter=default→ 2 files passed, 11 tests passed. Existing Reactact(...)warning in the barge-in suite is unchanged.npx eslint src/app/chat/composer/hooks/use-voice-conversation.ts src/app/chat/composer/hooks/use-voice-conversation-rearm.test.tsx→ passed.npm run typecheck→ passed.git diff --check→ passed.RED proof captured in
.automation/runs/20260911T1604Z/108301/fail-without-fix.txt: 3 regression tests failed on the pre-fix production code, each with the mic start count stuck at 1 instead of re-arming to 2.Duplicate / competitor check
108301 in:title,body state:open: none.Tranquil-Flow:fix/108301*: none before publication.Auto-published by Moonsong via Path B automated pipeline.