Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses SQLite result codes as the authoritative signal when gateway transcript writes decide whether to rebuild FTS and retry. The existing substring check treated any exception text containing
messages_ftsas FTS corruption, including constraint failures that should not trigger recovery.Explicit missing-table recovery remains supported for the three Hermes FTS tables because SQLite reports those trigger failures as
SQLITE_ERROR. The missing-table match is exact and accepts the schema-qualifiedmain.messages_ftsform emitted by real triggers without accepting lookalike table names.Related Issue
Refs #108130
Related to #97940
Type of Change
Changes Made
How to Test
HERMES_PYTHON=/path/to/python scripts/run_tests.sh tests/gateway/test_session.py -q.ruff check gateway/session_transcript.py tests/gateway/test_session.py.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) or N/Acli-config.yaml.exampleif I added/changed config keys or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows or N/A