Repository navigation
fix(desktop): recover remote OAuth without blocking healthy gateways - #108183
Merged
Merged
Conversation
Handle truncated OAuth responses and keep confirmed auth recovery stable. Preserve the current attempt guard before latching failures; the older pre-guard latch proposal is not carried forward. Co-authored-by: xxxigm <tuancanhnguyen706@gmail.com> Co-authored-by: FalconOrtiz <falcon.ortiz11@gmail.com> Co-authored-by: Ugo Enyioha <ugo.enyioha@outlook.com> Co-authored-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Ignore startup snapshots superseded by newer progress or an open socket. Co-authored-by: Carl Taylor <carl@carltaylor.com.au>
Queue a forced follow-up when Test overlaps an older enumeration; retain bounded caching for incidental focus events. Co-authored-by: FalconOrtiz <falcon.ortiz11@gmail.com>
૮ >ﻌ< ა ci reviewran on 4f5b4d7 — fix(desktop): refresh missing roster sources after recovery
|
This was referenced Sep 11, 2026
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keeps Desktop recoverable when a remote gateway restarts or rejects its saved session. Consolidates the remaining startup, response-stream, foreground-isolation, and roster-recovery fixes from the linked PRs.
Related issues and credit
Closes #72530.
Closes #101339.
Supersedes:
All contributors are credited in commit trailers. The larger route-identity architecture issue #90149 remains open and is not claimed fixed.
Type of change
Changes made
httpStatusErrorand prevent repeated response settlement.Current main already latches failures before awaiting teardown, checks attempt ownership before latching, uses connection-aware primary/pooled probes, scopes recovery logout to the failed gateway, and clears the latch on confirmed login. Those fixes are retained. This does not carry the unsafe pre-ownership latch reorder, message matching without a demonstrated production boundary, source-regex tests, or stale transport changes from the older PRs.
Verification
git diff --checkpasses.managed-ssh-update.test.tsandremote-lifecycle.test.ts; both also fail in an isolated rerun. No unrelated SSH code or tests were changed.The E2E gateway is an explicit loopback fixture, not the reporter's NAS or a hosted OAuth service. No real credentials or installed user state were used. Native Windows/Linux, packaged installers, the full renderer suite, and Python tests were not run.
Checklist