main is green again: anon-auth fixture resets the token memo to its dict shape - #107824
Merged
Merged
Conversation
…n-auth fixture #107611 (173105c) made _RESOLVE_TOKEN_CACHE a per-profile dict; #107697 (4bdd64b), merged from an older base, added a fixture resetting it to None. resolve_nous_access_token then raised AttributeError on .get, read_nous_access_token swallowed it and returned the expired token, and two tests in test_anon_auth_core.py went red on main.
Contributor
૮ >ﻌ< ა ci reviewran on fd9edee — test(auth): reset the resolve-token memo to its dict shape i
|
alt-glitch
added
type/test
Contributor
Duplicate of #107822 — same author, same two-line fixture change ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/hermes_cli/test_anon_auth_core.pyis green again on main (2 tests were red:test_tool_gateway_token_path_reexchanges,test_connector_path_replaces_a_dead_credential_once).Two PRs crossed: #107611 changed
hermes_cli.auth._RESOLVE_TOKEN_CACHEfromOptional[tuple]to a per-profiledict; #107697, merged an hour later from an older base, added a fixture resetting it toNone.resolve_nous_access_tokenraisedAttributeError: 'NoneType' object has no attribute 'get',read_nous_access_tokenswallowed it and handed back the expired token.Test-only, one token: reset to
{}(matchingtest_resolve_token_memo.pyandtest_nous_portal_staging_allowlist.py). No production change.test_anon_auth_core.py+test_resolve_token_memo.pySurfaced as an unrelated red on #107815.