fix(installer): support native Windows PowerShell install and CMD - #10565
fix(installer): support native Windows PowerShell install and CMD#10565adybag14-cyber wants to merge 24 commits into
Conversation
|
let me fix this |
a77a489 to
4832419
Compare
|
@chan-yuu @datalee @pangxianggang okay have a look |
1421e0c to
a576ca4
Compare
|
#8806 review this pull request here its fixed |
f19dfd9 to
a77ed4a
Compare
c56ff27 to
33fb803
Compare
33fb803 to
cc2dc54
Compare
46a3692 to
c626c71
Compare
|
#8821 #7689 #7298 I have added cmd , powershell 5.1 and 7.5 all fully compatible now with hermes straight up no other issues. |
|
@alt-glitch i have both cmd and powershell compatibility thus superseeding all other pr's for windows native |
|
@chan-yuu have a look |
|
@pangxianggang also have a look |
# Conflicts: # tools/environments/local.py # tools/process_registry.py
54e7f74 to
63028a0
Compare
|
Hi @adybag14-cyber |
|
Thanks for this — appreciate the work. We're closing the entire cluster of open native-Windows PRs (44 of them spanning installer, terminal routing, file ops, gateway PID handling, encoding, docs, and more) because the surface area needs a designed, consolidated approach rather than piecemeal merges. Cherry-picking individual fixes keeps leaving inconsistencies and we'd rather land Windows support properly, in one coherent pass.\n\nYour PR is catalogued in our internal Windows support plan. When we pick this back up (soon), we'll mine every PR in the cluster for its fix shape and credit all contributors whose work informs the final patch via lines. Watch for the consolidating PR and feel free to chime in with context on the specific failure mode you were hitting.\n\nClosing for now, not as a rejection of the fix — just queueing it for the designed rollout. Thanks again. |
What does this PR do?
This PR fixes native Windows installation so Hermes can be installed directly from stock PowerShell without requiring WSL.
The main issue was that the PowerShell installer used Unicode/banner characters that parsed inconsistently in native Windows PowerShell environments. This change makes the installer output Windows-PowerShell-safe while preserving installer behavior, and updates the README so Windows users are directed to the supported native PowerShell install path instead of being told to use WSL.
Why this approach:
Related Issue
No tracked GitHub issue found for this specific native Windows installer parsing/support gap.
Type of Change
Changes Made
scripts/install.ps1to use PowerShell-safe ASCII banner/status output instead of Unicode characters that were causing native Windows PowerShell issuesREADME.mdto document native Windows PowerShell installation and remove the old WSL-only guidanceHow to Test
irm https://raw.githubusercontent.com/NousResearch/hermes-agent/main/scripts/install.ps1 | iexhermes.exeexists under the installedvenv\Scriptsdirectory.hermes --helpfrom the installed path and confirm it starts successfully.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) or N/Acli-config.yaml.exampleif I added/changed config keys or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows or N/AScreenshots / Logs
Native Windows validation performed on this branch:
scripts/install.ps1%LOCALAPPDATA%venv\Scripts\hermes.exeexistshermes --helpruns successfully with no WSL involved