Repository navigation
test: Desktop deadline checks no longer race CI scheduling - #105448
Merged
Merged
Conversation
૮ >ﻌ< ა ci reviewran on 781211b — test: make desktop orphan-reap deadline checks deterministic
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop orphan-reap deadline tests no longer race CI scheduling before their first record.
evals/; production code and deadline behavior are unchanged.Root cause: the fixtures allowed only 1 ms of real time before the first iteration, so a scheduling pause correctly preserved both records instead of processing the first.
Live repro: scheduling-controlled execution of the real ownership module on base
2237be355906fbe6065ce1815711eee52b2d646eand post-merge main5280fe99872a58f1b9d25b00a79d240ecd035f7dreproduces the run 34171261707 assertion ([]instead of[62]). Both source and test files are byte-identical across those commits; this is preexisting, not caused by #105442. The deadline fixtures originated in #101929; existing-fix sweep found no superseding clock fix.Validation
>=deadline boundary to>(mutation control)The replay injects actual pauses, not fabricated timestamps; the corrected fixtures explicitly control time. Local dependency setup initially lacked desktop packages/Electron; a clean lockfile install and Electron install resolved that before the full green runs.
NODE_OPTIONS="--require=$PWD/evals/desktop-reap-clock-pressure.cjs" \ npm run test:desktop:platforms -w apps/desktop -- electron/backend-ownership.test.tsInfographic