fix(bot-mode): scope Bot Chat session lookup to the target profile's home

[yoyodine-industries]

Problem

message_agent delivery runs hermes -p <profile> chat --in '~' -c 'Bot Chat'. tools/bot_relay.py hard-coded the turn args as:

BOT_CHAT_TURN_ARGS = ("chat", "--in", "~", "-c", "Bot Chat", "--create-if-missing", "-Q")

--in ~ scopes the session lookup to the shared home directory, which for a named profile resolves to the default profile's workspace. When the default profile's Bot Chat session is held "live" by the desktop surface, delivery fails with already has a live owner, surfaced to the sender as target_busy — breaking DMs to any bot on the install (coder, majordomo, …).

Fix

Scope the -c "Bot Chat" lookup to the target profile's own home:

• tools/bot_mode_probe.py: add profile_home_dir(root, name) — root for "default", else root/profiles/<name> (inverse of the existing _hermes_root/_profile_name pair).
• tools/bot_relay.py: replace the constant BOT_CHAT_TURN_ARGS with _bot_chat_turn_args(profile, root), which builds the profile-scoped argv, and route local_delivery_command through it.
• tools/bot_mode_dm.py: message_agent_tool now passes _bot_chat_turn_args(resolved, root) into the delivery argv.

Test

• test_local_delivery_scopes_in_to_profile_home: asserts --in resolves to root/profiles/<profile> (and to root for the default profile).
• test_local_delivery_command_and_ack updated to the profile-scoped --in.

Both proven red on base, green with the fix.

scripts/run_tests.sh tests/tools/test_bot_relay_windows_paths.py tests/tools/test_bot_mode_dm.py tests/tools/test_bot_turn_lock.py

Related Issue

Fixes #105460

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ New feature (non-breaking change that adds functionality)
• 🔒 Security fix
• 📝 Documentation update
• ✅ Tests (adding or improving test coverage)
• ♻️ Refactor (no behavior change)
• 🎯 New skill (bundled or hub)

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix
• I've run scripts/run_tests.sh tests/tools/test_bot_relay_windows_paths.py tests/tools/test_bot_mode_dm.py tests/tools/test_bot_turn_lock.py and all tests pass
• I've added tests for my changes
• I've tested on my platform: macOS

Documentation & Housekeeping

• I've updated relevant documentation — or N/A (internal bug fix; no user-facing behavior change, in-code docstrings updated)
• I've updated cli-config.yaml.example — or N/A (no config keys added or changed)
• I've updated CONTRIBUTING.md or AGENTS.md — or N/A (no contribution/agent-instruction change)
• I've considered cross-platform impact (Windows, macOS) — or N/A (Path-based; Windows path test covers it)
• I've updated tool descriptions/schemas — or N/A (message_agent tool interface unchanged)

[teknium1]

Post-merge scope check: leaving this PR open, not treating it as superseded. #105442 (5280fe99872a58f1b9d25b00a79d240ecd035f7d) pins the target profile home for advertised live-owner ingress, but does not change BOT_CHAT_TURN_ARGS or the relay/local CLI --in ~ behavior addressed here. That working-directory/session-lookup proposal needs its own premise and behavior review; fixing live-owner admission alone does not establish that it is implemented or unnecessary. Thanks @yoyodine-industries for isolating the target-profile lookup concern.

[yoyodine-industries]

Ready for review — scopes Bot Chat session lookup to the target profile's home. Mergeable on current main; CI needs a maintainer to approve-and-run. Thanks!

[yoyodine-industries]

Merged current main in to clear the conflict — upstream reworked the relay sender plumbing in the meantime, so a plain rebase wasn't clean. Kept both sides: upstream's author=author and our _bot_chat_turn_args(resolved, root) scoping of the Bot Chat lookup to the target profile's home. Run: tests/tools/test_bot_mode_dm.py + tests/tools/test_bot_relay_windows_paths.py -> 55 passed, 1 skipped. Mergeable again.

[yoyodine-industries]

Closing as superseded, per your note on #105460: main's live-owner delivery path (5280fe99872a58f1b9d25b00a79d240ecd035f7d and follow-ups) already queues a DM into a bot whose Bot Chat is open in Desktop rather than refusing it, and the -c "Bot Chat" lookup resolves against the -p profile's own state.db — so the --in ~ premise behind this patch was wrong and the change isn't needed. Thanks for the precise scope check.

For the record: we're running v0.21.3 and have seen no target_busy refusal since; if one recurs we'll reopen or file fresh with a receipt, as you asked.