Skip to content

fix: /debug privacy — auto-delete pastes after 1 hour, add privacy notices - #10510

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-d32f18b9
Apr 15, 2026
Merged

teknium1 merged 1 commit into
mainfrom
hermes/hermes-d32f18b9

Conversation

@teknium1

Copy link
Copy Markdown
Collaborator

Summary

Addresses user privacy concern from Discord where /debug uploaded full conversation logs to a public paste service with no warning, no expiry, and no way to delete.

Changes

Auto-delete (1 hour TTL):

  • After uploading to paste.rs, a detached background process is spawned that sleeps for 1 hour then sends HTTP DELETE requests to clean up the pastes
  • Uses start_new_session=True so the cleanup survives the parent process exiting (important for CLI mode)
  • Best-effort — if the cleanup process dies, hermes debug delete <url> is available as a manual fallback

Privacy notices:

  • CLI hermes debug share: Shows a clear warning listing exactly what data will be uploaded before proceeding
  • Gateway /debug: Shows privacy notice in the response message

Gateway: reduced data exposure:

  • Gateway /debug now only uploads the summary report (system info + recent log tails), NOT full log files containing conversation content
  • Users who need full logs can use hermes debug share from the CLI

Manual delete command:

  • hermes debug delete <url> [<url>...] — sends DELETE to paste.rs for immediate cleanup
  • Works as a fallback if the auto-delete process doesn't fire

Files changed

  • hermes_cli/debug.py — auto-delete scheduling, privacy notices, delete helpers, delete CLI handler
  • gateway/run.py — gateway /debug: summary-only upload, privacy notice, auto-delete
  • hermes_cli/main.pyhermes debug delete argparse subcommand
  • tests/hermes_cli/test_debug.py — 16 new tests (45 total, all passing)

Test plan

python -m pytest tests/hermes_cli/test_debug.py -n0 -q  # 45 passed

…tices

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Supply Chain Risk Detected

This PR contains patterns commonly associated with supply chain attacks. This does not mean the PR is malicious — but these patterns require careful human review before merging.

⚠️ WARNING: Outbound network calls (POST/PUT)

Outbound POST/PUT requests in new code could be data exfiltration. Verify the destination URLs are legitimate.

Matches (first 10):

171:+    with urllib.request.urlopen(req, timeout=30) as resp:
193:+        f"[urllib.request.urlopen(urllib.request.Request(u, method='DELETE', "
554:+        with patch("hermes_cli.debug.urllib.request.urlopen",

Automated scan triggered by supply-chain-audit. If this is a false positive, a maintainer can approve after manual review.

@teknium1
teknium1 merged commit 1914281 into main Apr 15, 2026
6 of 7 checks passed
@teknium1
teknium1 deleted the hermes/hermes-d32f18b9 branch April 15, 2026 20:40
kagura-agent pushed a commit to kagura-agent/hermes-agent that referenced this pull request Apr 16, 2026
…tices (NousResearch#10510)

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
aj-nt pushed a commit to aj-nt/hermes-agent that referenced this pull request May 1, 2026
…tices (NousResearch#10510)

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…tices (NousResearch#10510)

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…tices (NousResearch#10510)

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…tices (NousResearch#10510)

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
…tices (NousResearch#10510)

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
…tices (NousResearch#10510)

- Pastes uploaded by /debug now auto-delete after 1 hour via a detached
  background process that sends DELETE to paste.rs
- CLI: shows privacy notice listing what data will be uploaded
- Gateway: only uploads summary report (system info + log tails), NOT
  full log files containing conversation content
- Added 'hermes debug delete <url>' for immediate manual deletion
- 16 new tests covering auto-delete scheduling, paste deletion, privacy
  notices, and the delete subcommand

Addresses user privacy concern where /debug uploaded full conversation
logs to a public paste service with no warning or expiry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant