fix(cron): preserve skill env passthrough in worker thread - #10459
Merged
Conversation
10 tasks
kshitijk4poor
added a commit
that referenced
this pull request
Apr 15, 2026
…gation Follow-up to #10459 (salvage of #7527). The copy_context() fix propagates ALL ContextVars into the cron worker thread, including credential_files. This test verifies that skill-declared required_credential_files are visible inside the worker thread, matching the existing env_passthrough regression test.
kshitijk4poor
added a commit
that referenced
this pull request
Apr 15, 2026
…gation (#10462) Follow-up to #10459 (salvage of #7527). The copy_context() fix propagates ALL ContextVars into the cron worker thread, including credential_files. This test verifies that skill-declared required_credential_files are visible inside the worker thread, matching the existing env_passthrough regression test.
kagura-agent
pushed a commit
to kagura-agent/hermes-agent
that referenced
this pull request
Apr 16, 2026
…gation (NousResearch#10462) Follow-up to NousResearch#10459 (salvage of NousResearch#7527). The copy_context() fix propagates ALL ContextVars into the cron worker thread, including credential_files. This test verifies that skill-declared required_credential_files are visible inside the worker thread, matching the existing env_passthrough regression test.
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
…gation (NousResearch#10462) Follow-up to NousResearch#10459 (salvage of NousResearch#7527). The copy_context() fix propagates ALL ContextVars into the cron worker thread, including credential_files. This test verifies that skill-declared required_credential_files are visible inside the worker thread, matching the existing env_passthrough regression test.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…gation (NousResearch#10462) Follow-up to NousResearch#10459 (salvage of NousResearch#7527). The copy_context() fix propagates ALL ContextVars into the cron worker thread, including credential_files. This test verifies that skill-declared required_credential_files are visible inside the worker thread, matching the existing env_passthrough regression test.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…gation (NousResearch#10462) Follow-up to NousResearch#10459 (salvage of NousResearch#7527). The copy_context() fix propagates ALL ContextVars into the cron worker thread, including credential_files. This test verifies that skill-declared required_credential_files are visible inside the worker thread, matching the existing env_passthrough regression test.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…gation (NousResearch#10462) Follow-up to NousResearch#10459 (salvage of NousResearch#7527). The copy_context() fix propagates ALL ContextVars into the cron worker thread, including credential_files. This test verifies that skill-declared required_credential_files are visible inside the worker thread, matching the existing env_passthrough regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked from #7527 by @helix4u onto current main.
When a cron job loads a skill that declares
required_environment_variables(e.g.NOTION_API_KEY), those vars get registered in aContextVar-based allowlist for sandbox passthrough. But the cron agent runs inside aThreadPoolExecutorworker thread, and Python'sThreadPoolExecutor.submit()does not propagateContextVarstate. The skill's env vars are registered in the scheduler thread's context but invisible in the worker thread where the agent executes.Fix:
contextvars.copy_context()before submitting, thenctx.run(agent.run_conversation, prompt)in the worker thread. This is the standard Python pattern for ContextVar propagation into thread pools.Bonus: This also propagates
credential_files.py's_registered_files_varContextVar — skills declaringrequired_credential_filesnow correctly pass those through in cron jobs too.Changes
cron/scheduler.py: 4-line fix —contextvars.copy_context()+ctx.run()wrappertests/cron/test_scheduler.py: regression test verifying env passthrough propagates into the worker threadTest plan
ThreadPoolExecutor.submit()loses ContextVars without the fix, andcopy_context().run()preserves them