refactor(installer): extract update marker region verbatim - #104379
Open
andrexibiza wants to merge 1 commit into
Open
andrexibiza wants to merge 1 commit into
andrexibiza wants to merge 1 commit into
Conversation
Contributor
PR #104379 — refactor(installer): extract update marker region verbatim Summary: Moves the update-marker guard region out of Findings (Non-blocking):
Verdict: Looks good. Clean verbatim extraction. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tauri bootstrap updater's update-marker region lives inside
apps/bootstrap-installer/src-tauri/src/update.rs. This extraction moves it verbatim into its own module so the ownership/refusal logic has a stable seam for the coordinated update-ownership lanes.Part of campaign #88683 and the installer sharding mandate #79922. Verbatim extraction, zero behavior change; the coordinated ownership work (#95719, #97299 and follow-up lanes) targets the extracted
update/marker.rsseam instead of the flattened file.What this is
apps/bootstrap-installer/src-tauri/src/update/marker.rs: the RAIIUpdateMarkerGuard,MarkerOwnerliveness/ownership inspection, self-heal refusal logic, andpid_is_alive— moved byte-for-byte.apps/bootstrap-installer/src-tauri/src/update.rs:mod marker;declaration plus the region removed; no other line changes.Verification
update.rsreappear inmarker.rsin the same order (script-verified line-by-line; zero missing lines);git diff --checkpasses.cargo testin the standalone worktree — 27 passed, 0 failed (extraction receipt identical on the standalone head); module wiring compiles.Provenance
Single verbatim refactor commit authored as Axl Ibiza, MBA
<andrexibiza@gmail.com>, pinned to current mainc8cbc07030459162a85058a57f8155c4d9efcde0. No behavior, ownership, or refusal semantics change; the coordinated ownership improvements remain separate lanes that target this new seam.