feat(memory): add per-user scoping to holographic memory plugin by nericervin · Pull Request #10427 · NousResearch/hermes-agent

nericervin · 2026-04-15T16:30:59Z

Summary

Adds per-user fact scoping to the Holographic memory plugin, allowing multi-tenant deployments where each user's memories are isolated.

Replaces #7256 (rebased on current main to resolve conflicts).

Changes

plugins/memory/holographic/store.py: Add user_scope column to facts table, filter queries by user when provided
plugins/memory/holographic/retrieval.py: Pass user_scope through retrieval pipeline
plugins/memory/holographic/__init__.py: Accept user_id parameter in memory plugin interface
gateway/platforms/api_server.py:
- Read X-Hermes-User-Id header for per-user memory scoping
- Pass user_id through _create_agent and _run_agent to the memory plugin
- Compatible with new streaming SSE callbacks (tool_start/tool_complete)

Use case

When Hermes serves multiple users via the API server (e.g. from an Odoo Discuss integration), each user's holographic memories should be isolated. Without this, all users share the same fact store, leading to cross-contamination of context.

The X-Hermes-User-Id header is set by the client (e.g. Odoo webhook) to identify the user.

Test plan

Verified on live multi-user deployment — facts are correctly scoped per user
Backwards compatible — when no X-Hermes-User-Id header is sent, behavior is unchanged (global scope)
No impact on other memory providers (Mem0, Honcho)

The holographic memory plugin stores all facts in a single global table without any user isolation. When multiple users share a Hermes instance via the API server gateway, every user's facts are visible to every other user — a data leak. This commit adds a `user_scope` column to the facts table and threads the gateway `user_id` (from the `X-Hermes-User-Id` header) through `AIAgent → HolographicMemoryProvider → MemoryStore → FactRetriever`. Changes: - store.py: `user_scope` column with composite unique index on (content, user_scope), auto-migration for existing databases, `scope_clause()` helper for consistent WHERE filtering - __init__.py: extract `user_id` from kwargs in `initialize()`, pass as `user_scope` to MemoryStore; scope `system_prompt_block` count query - retrieval.py: apply `scope_clause()` to all retrieval paths (FTS candidates, probe, related, reason, contradict, vector scoring) - api_server.py: read `X-Hermes-User-Id` header, pass through `_run_agent` → `_create_agent` → `AIAgent(user_id=...)` for all three endpoints (chat completions, responses, streaming) Backwards-compatible: when `user_id` is None (CLI sessions), all facts remain visible — no behaviour change for single-user setups. Follows up on NousResearch#5895 which threaded `user_id` to Mem0 and Honcho but left Holographic unscoped.

The previous commit added user_id to _run_agent and the handler calls but missed adding it to _create_agent's signature and to the AIAgent constructor call. This caused: "unexpected keyword argument 'user_id'" at runtime.

alt-glitch · 2026-04-26T02:22:46Z

Replaces closed #7256 (rebased on current main to resolve conflicts, per PR description).

nericervin · 2026-04-26T03:51:19Z

Hi @alt-glitch — thanks for confirming. Pushed a small follow-up commit to add my email to AUTHOR_MAP in scripts/release.py, which should clear the check-attribution failure.

Re: the failing test job: the 57 failures are unrelated to this PR's changes. They cover Discord adapters, Telegram polling, Matrix URL encoding, .venv detection, fast-mode preflight, GoogleAPI client imports, etc. — none touch plugins/memory/holographic/* or the gateway code paths modified here. Looks like preexisting flakiness on main. Happy to dig further if you'd like, but I don't think they were introduced by this PR.

teknium1

Thanks for tackling a real isolation gap. Current main already forwards AIAgent._user_id to memory providers (agent/agent_init.py:1384-1410), but API-server agents still do not receive one (gateway/platforms/api_server.py:1234-1363), so the core premise remains valid.

Problems

The existing-store migration is unsafe: current databases retain content TEXT NOT NULL UNIQUE (plugins/memory/holographic/store.py:19). Adding user_scope and a composite index does not remove that table constraint, so duplicate content for a second user still fails.
update_fact, remove_fact, and record_feedback remain fact-id-only (plugins/memory/holographic/store.py:262-325, 370-390), so the new read filters do not enforce scope for mutations.
Current main validates caller-provided memory scope in _parse_session_key_header (gateway/platforms/api_server.py:1088-1135). The new header needs equivalent validation and must also cover the newer persisted-session chat routes (gateway/platforms/api_server.py:1876-1995).

Suggested changes

Rebuild/migrate legacy tables to replace the old UNIQUE constraint; add an upgrade regression test.
Apply scope checks to every mutation and add cross-user mutation-denial coverage.
Generalize the current validated scope-header path and cover every API agent entry point.

Automated hermes-sweeper review.

teknium1 · 2026-07-12T12:47:09Z

+        # memory plugins (holographic, mem0, honcho) isolate facts per
+        # user.  When absent, all facts are visible (CLI behaviour).
+        provided_user_id = request.headers.get(
+            "X-Hermes-User-Id", ""


Please route this through a validated scope-header helper rather than accepting it directly. Current main's analogous X-Hermes-Session-Key parser requires API-key configuration and rejects unsafe or oversized values (gateway/platforms/api_server.py:1088-1135); this identifier becomes persistent tenant state.

teknium1 · 2026-07-12T12:47:09Z

+            self._conn.execute(
+                "CREATE UNIQUE INDEX IF NOT EXISTS idx_facts_content_user "
+                "ON facts(content, COALESCE(user_scope, ''))"
+            )


This does not replace the legacy table-level UNIQUE(content) constraint on existing databases; SQLite retains that constraint after ALTER TABLE ... ADD COLUMN. Rebuild/copy the table before relying on scoped duplicate inserts, and add an upgrade test with identical content under two scopes.

GottZ

This was generated by AI during triage.

Summary

Two PRs address the reported cross-user leakage in holographic memory by propagating an API-provided user ID into the memory store and filtering retrievals by that scope. #10427 is the rebased replacement for #7256, but its diff does not yet enforce isolation across legacy-schema migrations, mutations, header validation, and all persisted-session routes.

Related pull requests

#7256 [closed] duplicate — (+375/-30) — superseded duplicate: The holographic-memory portion adds the same user-scope column, API-header propagation, and scoped reads later carried by #10427, but this closed PR also bundles unrelated Mattermost, WhatsApp, lifecycle-status, and messaging-tool changes. It remains relevant as the original implementation, but was explicitly closed in favor of the rebased #10427.
#10427 related — (+148/-19) — keep open with a salvage path: The diff isolates many read and retrieval paths and forwards X-Hermes-User-Id through the API agent path, directly addressing cross-user reads. Consistent with the keep_open review on #10427, it still needs a table-rebuild migration that removes the legacy content UNIQUE constraint, scope checks on update_fact/remove_fact/record_feedback, validated caller scope equivalent to _parse_session_key_header, and coverage of the newer persisted-session chat routes.

Duplicates

#7256 and #10427 implement substantially the same holographic-memory scoping change; #10427 explicitly replaces #7256, so #7256 should remain closed as a duplicate of #10427.

Suggested consolidation

Keep open with a salvage path for #10427: retain its focused API user-ID propagation and scoped retrieval work, then address the concrete isolation gaps identified by the contributor keep_open review—legacy-table reconstruction, mutation scoping, header validation, and persisted-session route coverage. Keep #7256 closed as a duplicate of #10427 because its relevant memory changes were superseded and its diff also contains unrelated platform-specific modifications.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    subgraph Dup7256 ["PRs duplicating each other"]
        P7256["PR #7256 (closed)"]
        P10427["PR #10427 (open)"]
    end
    class P7256 closed
    class P10427 open
    class P10427 target
    click P7256 "https://github.com/NousResearch/hermes-agent/pull/7256"
    click P10427 "https://github.com/NousResearch/hermes-agent/pull/10427"

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 51 kB of PR diffs, 3 kB of issue/PR text, 2 kB of discussion (4 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

nericervin added 2 commits April 15, 2026 13:26

fix(memory): pass user_id param to _create_agent and AIAgent

84f2309

The previous commit added user_id to _run_agent and the handler calls but missed adding it to _create_agent's signature and to the AIAgent constructor call. This caused: "unexpected keyword argument 'user_id'" at runtime.

alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins comp/gateway Gateway runner, session dispatch, delivery tool/memory Memory tool and memory providers labels Apr 26, 2026

chore(release): add nericervin to AUTHOR_MAP

10639c9

teknium1 reviewed Jul 12, 2026

View reviewed changes

GottZ reviewed Jul 30, 2026

View reviewed changes

advaitbd mentioned this pull request Aug 12, 2026

feat(memory): add scoped paths and tools-only holographic mode #84382

Open

Navigation Menu

feat(memory): add per-user scoping to holographic memory plugin - #10427

feat(memory): add per-user scoping to holographic memory plugin#10427
nericervin wants to merge 3 commits into
NousResearch:mainfrom
nericervin:feat/holographic-user-scoping

nericervin commented Apr 15, 2026

Uh oh!

alt-glitch commented Apr 26, 2026

Uh oh!

nericervin commented Apr 26, 2026

Uh oh!

teknium1 left a comment

Uh oh!

teknium1 Jul 12, 2026

Uh oh!

teknium1 Jul 12, 2026

Uh oh!

GottZ left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nericervin commented Apr 15, 2026

Summary

Changes

Use case

Test plan

Uh oh!

alt-glitch commented Apr 26, 2026

Uh oh!

nericervin commented Apr 26, 2026

Uh oh!

teknium1 left a comment

Choose a reason for hiding this comment

Problems

Suggested changes

Uh oh!

teknium1 Jul 12, 2026

Choose a reason for hiding this comment

Uh oh!

teknium1 Jul 12, 2026

Choose a reason for hiding this comment

Uh oh!

GottZ left a comment

Choose a reason for hiding this comment

Summary

Related pull requests

Duplicates

Suggested consolidation

Complex graph

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants