Repository navigation
Conversation
Related: #100418 and #102627 are competing fixes for the same #100401 fence-contention bug. This PR renews the lease without taking the delivery fence; #100418 treats a busy fence as non-loss; #102627 tri-states the heartbeat result. Linking so reviewers can compare approaches. |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cron delivery holds the per-job fire fence across network I/O. The concurrent claim heartbeat attempts that same fence and fails closed after 30 seconds of contention. The scheduler mistakes this for ownership loss, marking successfully executed/delivered runs interrupted.
Production evidence: output saved 06:32:03, local fence timeout 06:32:49, confirmed Discord delivery 06:32:53, then an interrupted execution record. The actual gateway restart was later, at 06:40:48.
Fix
Verification
scripts/run_tests.sh tests/cron/ -j 8 --file-retries 0: 1,227 passed, 0 failed, 2 skipped across 96 files. Independent contention probe again passed with the strict-lock follow-up.