Skip to content

Adding Minimax support for image generation - #10389

Closed
notoriousmic wants to merge 2 commits into
NousResearch:mainfrom
notoriousmic:main
Closed

Adding Minimax support for image generation#10389
notoriousmic wants to merge 2 commits into
NousResearch:mainfrom
notoriousmic:main

Conversation

@notoriousmic

Copy link
Copy Markdown

What does this PR do?

Related Issue

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • Added a new tool, minimax_image_generate, implemented in tools/minimax_image_tool.py, which calls the MiniMax image-01 model API to generate images from text prompts and returns a URL or file path to the generated image. The tool handles API key management, error reporting, and aspect ratio selection.
  • Registered minimax_image_generate in the tool registry, including its schema, handler, requirements check, and environment variable dependency.
  • Updated tool grouping and toolset definitions to include minimax_image_generate in the image_gen and image_tools categories in toolsets.py and model_tools.py. [1] [2] [3] [4]

Configuration and Environment Variables:

  • Added MINIMAX_API_KEY to .env.example and integrated its management in the configuration system, ensuring users are prompted for the API key when using the MiniMax tool. [1] [2] [3]
  • Updated the plugin/toolset configuration to recognize MiniMax as a provider, including badge, description, and environment variable prompts.

User Interface and Tool Preview:

  • Updated tool preview and display logic to support and correctly label minimax_image_generate actions in the UI, ensuring prompts and results are shown consistently with other image generation tools. [1] [2]
  • Included minimax_image_generate in the list of available tools and prompts for subscription/activation.

How to Test

  1. Ask Hermes to generate image after providing minimax api key

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

image

@notoriousmic

notoriousmic commented Apr 16, 2026

Copy link
Copy Markdown
Author

Issues on this topic:
#10749
#7347

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/tools Tool registry, model_tools, toolsets tool/vision Vision analysis and image generation provider/minimax MiniMax (Anthropic transport) labels Apr 26, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the MiniMax image-generation implementation.

This automated hermes-sweeper review is closing it under the standing third-party provider-integration policy: vendor integrations should ship as standalone plugins rather than add another core model tool. Current main has one image_generate tool that dispatches through the ImageGenProvider registry (tools/image_generation_tool.py:1274, :1513), and the picker discovers those providers dynamically (hermes_cli/tools_config.py:2197).

  • This PR instead adds a separate core minimax_image_generate tool (tools/minimax_image_tool.py:199 in the PR diff), duplicating the image-generation surface.
  • A standalone MiniMax image backend can register through ~/.hermes/plugins/image_gen/minimax/ or a pip entry point, preserving the existing picker, provider selection, response contract, and single-tool schema.
  • The linked discussion already identifies an external plugin path, and related PR feat(image-gen): add MiniMax image-01 backend plugin #25451 follows the provider-plugin architecture.

The implementation work is useful; please publish or continue it as a standalone plugin repository and share it in #plugins-skills-and-skins.


Closed as not-planned per standing maintainer policy (in-tree-provider-integration). This is a design-direction decision, not a code-quality judgment — see the Contribution Rubric in AGENTS.md for what the project is looking for. If you believe this policy was misapplied to your change, comment here and a maintainer will take a look.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added the sweeper:not-planned Sweeper: closed per standing maintainer policy (design direction) label Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have provider/minimax MiniMax (Anthropic transport) sweeper:not-planned Sweeper: closed per standing maintainer policy (design direction) tool/vision Vision analysis and image generation type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants