You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🐛 Bug fix (non-breaking change that fixes an issue)
✨ New feature (non-breaking change that adds functionality)
🔒 Security fix
📝 Documentation update
✅ Tests (adding or improving test coverage)
♻️ Refactor (no behavior change)
🎯 New skill (bundled or hub)
Changes Made
Added a new tool, minimax_image_generate, implemented in tools/minimax_image_tool.py, which calls the MiniMax image-01 model API to generate images from text prompts and returns a URL or file path to the generated image. The tool handles API key management, error reporting, and aspect ratio selection.
Registered minimax_image_generate in the tool registry, including its schema, handler, requirements check, and environment variable dependency.
Updated tool grouping and toolset definitions to include minimax_image_generate in the image_gen and image_tools categories in toolsets.py and model_tools.py. [1][2][3][4]
Configuration and Environment Variables:
Added MINIMAX_API_KEY to .env.example and integrated its management in the configuration system, ensuring users are prompted for the API key when using the MiniMax tool. [1][2][3]
Updated the plugin/toolset configuration to recognize MiniMax as a provider, including badge, description, and environment variable prompts.
User Interface and Tool Preview:
Updated tool preview and display logic to support and correctly label minimax_image_generate actions in the UI, ensuring prompts and results are shown consistently with other image generation tools. [1][2]
Included minimax_image_generate in the list of available tools and prompts for subscription/activation.
How to Test
Ask Hermes to generate image after providing minimax api key
Thanks for the MiniMax image-generation implementation.
This automated hermes-sweeper review is closing it under the standing third-party provider-integration policy: vendor integrations should ship as standalone plugins rather than add another core model tool. Current main has one image_generate tool that dispatches through the ImageGenProvider registry (tools/image_generation_tool.py:1274, :1513), and the picker discovers those providers dynamically (hermes_cli/tools_config.py:2197).
This PR instead adds a separate core minimax_image_generate tool (tools/minimax_image_tool.py:199 in the PR diff), duplicating the image-generation surface.
A standalone MiniMax image backend can register through ~/.hermes/plugins/image_gen/minimax/ or a pip entry point, preserving the existing picker, provider selection, response contract, and single-tool schema.
The implementation work is useful; please publish or continue it as a standalone plugin repository and share it in #plugins-skills-and-skins.
Closed as not-planned per standing maintainer policy (in-tree-provider-integration). This is a design-direction decision, not a code-quality judgment — see the Contribution Rubric in AGENTS.md for what the project is looking for. If you believe this policy was misapplied to your change, comment here and a maintainer will take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/toolsTool registry, model_tools, toolsetsP3Low — cosmetic, nice to haveprovider/minimaxMiniMax (Anthropic transport)sweeper:not-plannedSweeper: closed per standing maintainer policy (design direction)tool/visionVision analysis and image generationtype/featureNew feature or request
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related Issue
Changes Made
minimax_image_generate, implemented intools/minimax_image_tool.py, which calls the MiniMax image-01 model API to generate images from text prompts and returns a URL or file path to the generated image. The tool handles API key management, error reporting, and aspect ratio selection.minimax_image_generatein the tool registry, including its schema, handler, requirements check, and environment variable dependency.minimax_image_generatein theimage_genandimage_toolscategories intoolsets.pyandmodel_tools.py. [1] [2] [3] [4]Configuration and Environment Variables:
MINIMAX_API_KEYto.env.exampleand integrated its management in the configuration system, ensuring users are prompted for the API key when using the MiniMax tool. [1] [2] [3]User Interface and Tool Preview:
minimax_image_generateactions in the UI, ensuring prompts and results are shown consistently with other image generation tools. [1] [2]minimax_image_generatein the list of available tools and prompts for subscription/activation.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs