fix(weixin): preserve native markdown rendering - #10338
Closed
bernylinville wants to merge 1 commit into
Closed
Conversation
- stop rewriting markdown tables, headings, and links before delivery - keep markdown table blocks and headings together during chunking - update Weixin tests and docs for native markdown rendering Closes NousResearch#10308
Contributor
|
Merged as part of Batch-3 salvage: #11571 Your commit cherry-picked onto Commit SHAs on main: 6ee65b4 |
1 task
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The Weixin adapter assumed WeChat could not render Markdown well, so
format_message()rewrote outgoing content before delivery:That behavior now degrades real Weixin output because the current client can render Markdown tables natively.
Testing
source venv/bin/activate && python -m pytest tests/gateway/test_weixin.py -qCloses #10308