Skip to content

fix(gateway): reduce false duplicate-send alarms - #103160

Open
hermes-slape2 wants to merge 1 commit into
NousResearch:mainfrom
hermes-slape2:fix/stream-delivery-warning-noise
Open

hermes-slape2 wants to merge 1 commit into
NousResearch:mainfrom
hermes-slape2:fix/stream-delivery-warning-noise

Conversation

@hermes-slape2

Copy link
Copy Markdown

Summary

  • Classify stream consumers with no final-delivery signal as normal-final-send cases, not duplicate-send warnings.
  • Retain warning-level diagnostics only when a delivery signal exists but cannot prove the completed reply.
  • Add regression coverage for the no-signal path.

Why
All 34 alerts in the investigated window had streamed=false, previewed=false, and content_delivered=false. The normal final send was therefore the sole delivery path; a duplicate was impossible from that state.

Validation

  • uv run ruff check gateway/run_turn.py tests/gateway/test_suppression_contract_matrix.py
  • uv run pytest tests/gateway/test_suppression_contract_matrix.py -v (40 passed, 1 expected xfail)

@grantslape

Copy link
Copy Markdown

Please reach out to me directly regarding this PR. Sorry if this is causing noise.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants