Conversation
shellybotmoyer
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean 3-file fix (+16/-4) raising the warm backend pool cap from 3 to 8. Reasonable default for desktop use cases where multiple model providers may be configured. Straightforward config improvement.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop's warm-backend pool capped concurrent spawned bot backends at 3 by default. On a multi-bot roster (the reporter runs 6: 1 remote + 5 local) the LRU cap evicts the least-recently-used idle backend as soon as a 4th is opened, so earlier bots pay a cold start every time they're revisited — matching the "ones I created first become no longer accessible until I re-prompt Hermes" report in #102822.
HERMES_DESKTOP_POOL_MAXenv fallback); only the default was stale — it preserved the original hard-coded ceiling from before multi-bot rosters were common.maxBackends3 → 8 in both authoritative places:apps/desktop/electron/pool-limits.ts(main process: pool + persisted preference) and its hand-mirrored renderer copyapps/desktop/src/store/pool-limits.ts(Settings rows +prewarmProfileBackendsaturation guard). Values already persisted inuserDataare untouched — users who lowered the cap keep theirs.Testing
npx vitest run electron/pool-limits.test.ts --project electron— 9 passed (incl. new pinning test)npx vitest run electron/pool-spawn-coordinator.test.ts electron/pool-eviction.test.ts --project electron— 22 passednpx vitest run src/store/profile.test.ts --project ui— 20 passednpx tsc --build tsconfig.electron.json— exit 0npx tsc -p . --noEmit(renderer) — exit 0eslinton all three touched files — exit 0Fixes #102822