fix(models): use curated list for Nous in provider_model_ids() - #10243
Closed
teknium1 wants to merge 1 commit into
Closed
fix(models): use curated list for Nous in provider_model_ids()#10243teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
provider_model_ids('nous') was calling fetch_nous_models() which
returns the FULL live Nous API catalog (382 models including image
generators, rerankers, and non-agentic models). This caused the
/model picker fallback to dump hundreds of models into the list,
making it unusable.
PR #10146 fixed the /model picker to prefer the curated list first,
but the fallback still called provider_model_ids() which returned
382 models. On WSL2 environments where stale .pyc caches prevented
the #10146 fix from taking effect, users saw the full catalog.
Fix: Return the curated _PROVIDER_MODELS['nous'] list (29 models)
directly, matching the pattern used by hermes model, the gateway
picker, and the OpenRouter flow (which also uses curated lists
cross-referenced against the live API rather than raw live data).
Before: provider_model_ids('nous') → 382 models (live API)
After: provider_model_ids('nous') → 29 models (curated)
Contributor
Author
|
Superseded by #12671. Root cause was in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider_model_ids('nous')was callingfetch_nous_models()which hits the live Nous Portal/modelsendpoint and returns the full API catalog — 382 models including image generators, rerankers, embedding models, and other non-agentic models.This caused the
/modelpicker's fallback (when the curated list was unavailable due to stale.pyccaches on WSL2) to dump hundreds of models into the picker, making it scroll off-screen and unusable.Root cause: PR #10146 fixed the
/modelpicker to prefer the curated list first. But the fallback still calledprovider_model_ids(), which for Nous returned 382 live models. On WSL2 where.pyctimestamp mismatches prevented the #10146 fix from being compiled, users saw the full catalog.Fix
Return the curated
_PROVIDER_MODELS['nous']list (29 models) directly, matching:hermes model(uses_PROVIDER_MODELS)/modelpicker (useslist_authenticated_providers()→ curated)fetch_openrouter_models()→ curated cross-ref)provider_model_ids('nous')provider_model_ids('openrouter')provider_model_ids('anthropic')Test plan
provider_model_ids('nous')confirmed returning 29 models