fix(gateway): fix matrix lingering typing indicator - #10239
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Matrix typing indicator lingering for ~30 seconds after Hermes has already sent a response.
Matrix typing events were sent with a
30000ms timeout, but the Matrix adapter inherited the basestop_typing()no-op. As a result, cleanup calls after agent completion did not send a “typing stopped” event, so Matrix clients kept showing Hermes as typing until the timeout expired.This PR adds a Matrix-specific
stop_typing()implementation that callsset_typing(..., timeout=0), whichmautrixsends astyping: false.Testing
Result:
Related Issue
Fixes #6016
Type of Change
Changes Made
MatrixAdapter.stop_typing()to explicitly clear Matrix typing state.timeout=0.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A