[codex] Fix gateway status ps fallback on WSL - #10076
Closed
qwertlooker wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
|
Closing as superseded by #22860. Triage notes (high confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
hermes gateway status/hermes statusprocess detection on WSL and Ubuntu variants whereps eww -ax -o ...is rejected by procps.Root Cause
The non-Windows gateway PID scan used a mixed BSD-style
ps eww -ax -o pid=,command=invocation. On the reporter's WSL/Ubuntu environment, that command failed, so gateway process discovery returned no manual gateway PIDs and status commands incorrectly reported that the gateway was not running.What Changed
ps -eww -ax -o pid=,command=for Linux/WSL process scans.ps -ax -o pid=,command=if the extended-environment form is unsupported.psfailure followed by fallback success.Impact
hermes gateway statusandhermes statusnow correctly detect manually running gateways on more Linux/WSL procps variants instead of producing false negatives.Validation
python -m pytest tests/hermes_cli/test_update_gateway_restart.py -q -k "falls_back_when_primary_ps_flags_fail or filters_to_current_profile or no_exclude_returns_all or excludes_specified_pids"python -m pytest tests/hermes_cli/test_gateway_wsl.py -q -k "test_status_wsl_running_manual or test_status_wsl_not_running"Notes
Broader gateway suites still have pre-existing Windows-environment failures in this checkout around
launchd/systemdpaths and missing async pytest support; they are unrelated to this change.