fix(compression): add explicit auxiliary context_length config - #10072
Closed
zkytech wants to merge 1 commit into
Closed
fix(compression): add explicit auxiliary context_length config#10072zkytech wants to merge 1 commit into
zkytech wants to merge 1 commit into
Conversation
Author
|
Closing this PR because already includes this functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auxiliary.compression.context_lengthconfig key to the default configcli-config.yaml.exampleand cover it with a regression testCloses #8810.
Context
This PR keeps the scope intentionally narrow: it only adds the explicit auxiliary compression context override requested in #8810.
I checked related work before opening this PR:
auxiliary.compression.context_lengthconfig surface requested by Feature: add explicit auxiliary.compression.context_length config #8810Changes
run_agent.py: readauxiliary.compression.context_lengthand forward it toget_model_context_length(..., config_context_length=...)during_check_compression_model_feasibility()hermes_cli/config.py: addauxiliary.compression.context_lengthtoDEFAULT_CONFIGcli-config.yaml.example: document the new config key for custom OpenAI-compatible endpointstests/run_agent/test_compression_feasibility.py: add regression coverage that the explicit override is forwarded and used by the warning pathTesting
source venv/bin/activate && python -m pytest tests/run_agent/test_compression_feasibility.py -qContribution Guide Notes
CONTRIBUTING.mdbefore submitting