Skip to content

fix(security): tag untrusted senders in Slack threads #10035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AntAISecurityLab wants to merge 1 commit into from
Closed

fix(security): tag untrusted senders in Slack threads #10035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion gateway/platforms/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,7 +1457,19 @@ async def _fetch_thread_context(
is_parent = msg_ts == thread_ts
prefix = "[thread parent] " if is_parent else ""
name = await self._resolve_user_name(msg_user, chat_id=channel_id)
context_parts.append(f"{prefix}{name}: {msg_text}")

# Tag messages from users not on the allowlist
trust_tag = ""
allow_all = os.getenv("SLACK_ALLOW_ALL_USERS", "").lower() in ("true", "1", "yes") or \
os.getenv("GATEWAY_ALLOW_ALL_USERS", "").lower() in ("true", "1", "yes")
if not allow_all:
allowed_csv = os.getenv("SLACK_ALLOWED_USERS", "").strip()
if allowed_csv:
allowed_ids = {uid.strip() for uid in allowed_csv.split(",") if uid.strip()}
if "*" not in allowed_ids and msg_user not in allowed_ids:
trust_tag = "[Message from untrusted user] "

context_parts.append(f"{prefix}{trust_tag}{name}: {msg_text}")

content = ""
if context_parts:
Expand Down