fix(simplex): scope multiplex secondary-profile config, not shared env

[nftpoetrist]

What & why

The SimpleX adapter's __init__ (auto_accept, group allowlist), check_requirements, validate_config, is_connected, _env_enablement, and _standalone_send all read SIMPLEX_* settings via raw os.getenv unconditionally.

Under a multiplexed gateway, a secondary profile's adapter construction and config-load hooks run inside a profile-scoped context (_profile_runtime_scope) where os.environ still holds the default profile's YAML-to-env bridge output. A secondary profile with its own (different, or absent) SimpleX configuration silently inherits the default profile's:

• daemon WebSocket URL (SIMPLEX_WS_URL) — cron/mid-turn delivery via _standalone_send connects to the wrong daemon
• group allowlist (SIMPLEX_GROUP_ALLOWED) — a secondary profile's own, possibly tighter, allowlist gets silently widened to the default profile's (e.g. the default's * wildcard)
• auto-accept setting (SIMPLEX_AUTO_ACCEPT)

check_requirements/_env_enablement also gate/seed platform enablement off the default profile's env during load_gateway_config(), which itself runs inside the secondary profile's scope.

Note: SIMPLEX_ALLOWED_USERS/SIMPLEX_ALLOW_ALL_USERS (the DM allowlist) are unaffected — those already route through the generic, already-scoped gateway/authz_mixin.py::_auth_env() mechanism via register()'s allowed_users_env/allow_all_env.

Fix

Mirrors the established Buzz adapter fix for the same bug class (#98738):

• _profile_scoped() / _scoped_platform_setting() — a secondary profile's own PlatformConfig.extra becomes authoritative and env is not consulted; a missing key fails closed to the safe default instead of borrowing the default profile's value. Single-profile gateways and the default profile under multiplexing keep the legacy os.getenv precedence unchanged.
• _profile_simplex_extra() — check_requirements() has no PlatformConfig argument, so (like Buzz's _profile_buzz_extra()) it reads the profile's own config.yaml directly via the scoped home override when running inside a secondary profile's scope.
• _env_enablement() returns None under a secondary profile's scope, so it does not fabricate a SimpleX platform for a profile that never configured one from the default profile's env.

Tests

Added TestMultiplexProfileScope to tests/gateway/test_simplex_plugin.py (7 tests), mirroring the existing Buzz adapter coverage for this exact scenario: secondary profile's extra wins over default's env, missing keys fail closed to safe defaults (not the default's wildcard/disabled values), the default profile stays unscoped and keeps env precedence, check_requirements consults the profile's own config.yaml, validate_config/is_connected respect scope, _env_enablement returns None when scoped, and _standalone_send connects to the scoped daemon URL rather than the default's.

• tests/gateway/test_simplex_plugin.py — 23 passed (16 pre-existing + 7 new)
• Mutation-verify: reverting the adapter fix makes 6 of the 7 new tests fail as expected (the 7th, the default-profile-unscoped case, was never buggy)
• Adjacent suites unaffected: tests/hermes_cli/test_send_cmd.py, tests/gateway/test_channel_directory.py, tests/gateway/test_unauthorized_dm_behavior.py — 45 passed

Scope note / prior art check

Three open PRs currently touch plugins/platforms/simplex/adapter.py + tests/gateway/test_simplex_plugin.py — checked each diff directly and confirmed zero function-level overlap with this fix (textual proximity only, same files, different functions/concerns):

• fix(simplex): authorize allowed-group messages at the gateway #52241 — adds role_authorized to the group-message dispatch in _handle_chat_item (gateway authorization signal), unrelated to env/profile scoping
• fix(gateway): match SimpleX allowlist on local alias, not spoofable profile name #41246 — resolves contact/member names via localDisplayName in _handle_new_chat_item (allowlist spoofing via display-name), unrelated
• fix(simplex): acquire scoped platform lock to prevent duplicate inbound processing #35523 — adds a platform lock around the WebSocket connectivity check in connect() (duplicate-listener prevention), unrelated

Merged PR #65629 (multiplex credential isolation cluster) does not touch this file — confirmed via gh pr view --json files.

[Enough1122]

AI code review — automated review for reference; please use your judgment.

This PR makes the SimpleX adapter multiplex-profile-aware, mirroring the Buzz fix (#98738): under a secondary-profile secret scope, os.environ holds the default profile's bridged YAML-to-env output, so all SIMPLEX_* reads are routed through _scoped_platform_setting (plugins/platforms/simplex/adapter.py:26), which consults PlatformConfig.extra instead. The fail-closed behavior is consistent across every site — auto-accept defaults to on, group allowlist to empty, _env_enablement to None, and check_requirements reads the profile's own config.yaml via _profile_simplex_extra (adapter.py:44). The docstrings correctly explain why env must never be consulted inside a scope.

Test coverage is excellent: the multiplex fixtures keep the suite hermetic, and the standalone-send test correctly manages the ContextVar token within the same asyncio task context (test_simplex_plugin.py:367).

Non-blocking: the scoped group-allowlist read assumes group_allowed is string-typed in extra — a YAML list value would reach _parse_comma_list and raise on .split(",") (adapter.py:103-104). No coercion/type guard is applied unlike the auto-accept path which str()-casts.

Verdict: LGTM

[teknium1]

Thanks @nftpoetrist for this PR — Merged via #101252 (2e25b47) on current main.

This one was rewritten onto the shared _get_scoped_secret primitive so all the scoped-secret lookups go through a single path instead of per-site logic; your other five PRs in this series were cherry-picked as-is. You're credited via Co-authored-by on the merge and in the PR body of #101252.

Closing this PR as superseded by the merged work.