This repository was archived by the owner on Aug 17, 2026. It is now read-only.
feat: hide canonical Bot Chats from the global Sessions sidebar (#46) - #64
Merged
Conversation
Bot Chats are plugin-owned forever-chats but were byte-identical to ordinary
desktop sessions, so they cluttered the global Sessions sidebar. Core
hermes-agent#86797 added a generic 'hidden' session flag (sidebar-hide, still
fully resumable). This wires it up:
- $hideBotChats pref (default ON), persisted via ctx.storage('hide-bot-chats').
- createCanonicalChat passes hidden:true on session.create when the pref is on
(core defers it via pending_hidden until the row exists).
- setHideBotChats(): flips + persists the pref and reconciles EXISTING canonical
chats via the session.set_hidden RPC (bounded batch over $botMeta[*].chat).
- Eye toggle in the Bots header (eye-closed = hidden) to flip it live.
Feature-detected by omission: older gateways ignore the unknown hidden param /
lack session.set_hidden, so Bot Chats simply stay visible — no breakage. Bot
Chats keep source=desktop (no platform mis-tag). Requires the core flag
(hermes-agent#86797, merged) + gateway restart to take effect. Tests: hidden
passed when pref on / omitted when off / toggle reconciles. Full suite 52/52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46.
Bot Chats are plugin-owned forever-chats but were byte-identical to ordinary desktop sessions, so they cluttered the global Sessions sidebar. Core hermes-agent#86797 added a generic
hiddensession flag (sidebar-hide, still fully resumable by its owning surface). This wires it up:$hideBotChatspref (default ON), persisted viactx.storage('hide-bot-chats').createCanonicalChatpasseshidden:trueonsession.createwhen the pref is on (core defers it viapending_hiddenuntil the row exists).setHideBotChats(): flips + persists the pref and reconciles existing canonical chats via thesession.set_hiddenRPC (bounded batch over$botMeta[*].chat).eye-closed= hidden) to flip it live.Graceful degradation: older gateways ignore the unknown
hiddenparam / lacksession.set_hidden, so Bot Chats simply stay visible — no breakage. Bot Chats keepsource=desktop(no agent platform mis-tag, unlike a source-retag approach).Requires the core flag (hermes-agent#86797, merged) + a gateway restart to take effect. Tests: hidden passed when pref on / omitted when off / toggle reconciles existing chats. Full suite 52/52.