This repository was archived by the owner on Aug 17, 2026. It is now read-only.
fix: scope Routines pane to each bot's own cron store (#37) - #63
Merged
Conversation
The Routines pane queried cron.manage without a profile, so it only ever saw the launch/default gateway's cron store. A bot whose profile keeps cron in ~/.hermes/profiles/<name>/cron/ (esp. when that profile runs a separate gateway) showed 'no cron jobs'. Core hermes-agent#86796 added an optional profile param to cron.manage. This plugin change threads the active bot through it: - loadRoutines(profile) / useRoutines(profile): pass profile on list + legacy- pause, and key the query by profile so switching bots refetches. - RoutineRow: forward profile on pause/resume/remove. - CreateRoutineDialog: pass profile: bot on add. Feature-detected by omission: older gateways ignore the unknown param and return the launch store, where the existing [bot:] tag filter (selectRoutineJobs) remains the graceful fallback. Source-assertion tests cover all four call sites. Full suite 49/49.
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37.
The Routines pane queried
cron.managewithout a profile, so it only saw the launch/default gateway's cron store. A bot whose profile keeps cron in~/.hermes/profiles/<name>/cron/(especially when that profile runs a separate gateway) showed 'no cron jobs'.Core hermes-agent#86796 added an optional
profileparam tocron.manage. This threads the active bot through it:loadRoutines(profile)/useRoutines(profile): passprofileon list + legacy-pause, and key the query by profile so switching bots refetches.RoutineRow: forwardprofileon pause/resume/remove.CreateRoutineDialog: passprofile: boton add.Graceful degradation: older gateways ignore the unknown param and return the launch store, where the existing
[bot:]tag filter (selectRoutineJobs) remains the fallback — so the plugin just works on any gateway.Requires the core RPC (hermes-agent#86796, merged) + a gateway restart to take full effect. Source-assertion tests cover all four call sites. Full suite 49/49.