Add multiple mattermost channel support #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch based on below PR NotSqrt#3 which add multiple mattermost channel support. To add a webhook to a project, add url like below http://<this-project-server:port>/new_event?mattermost_webhook_url=<mattermost channel webhook url> Signed-off-by: Chengwei Yang <[email protected]>
|
That would be really nice if you could update the tests and the docs to reflect this new feature ! |
fsobanski
pushed a commit
to iteratec/mattermost-integration-gitlab
that referenced
this pull request
Jul 24, 2017
This pull request is based on PR NotSqrt#4. Instead of setting MATTERMOST_WEBHOOK_URL when starting the server, the url must now be passed as an url parameter in the form http://<this-project-server:port>/new_event?mattermost_webhook_url=<mattermost channel webhook url> I updated the tests and the readme, just as @NotSqrt requested in PR NotSqrt#4. This commit should fix issue NotSqrt#2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch based on below PR
#3
which add multiple mattermost channel support.
To add a webhook to a project, add url like below
http://this-project-server:port/new_event?mattermost_webhook_url=
Signed-off-by: Chengwei Yang [email protected]