Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare NPE in crystal hollow chest highlighter #1019

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix rare NPE in crystal hollow chest highlighter #1019

merged 1 commit into from
Feb 29, 2024

Conversation

nea89o
Copy link
Member

@nea89o nea89o commented Feb 14, 2024

No description provided.

@nea89o nea89o marked this pull request as ready for review February 14, 2024 19:02
@jani270 jani270 added the bug-fix This PR fixes a bug label Feb 15, 2024
@hannibal002 hannibal002 self-requested a review February 29, 2024 08:53
hannibal002
hannibal002 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. Have not tested in game (I have not set player or world to null for testing purposes)

@hannibal002 hannibal002 merged commit 191bf59 into master Feb 29, 2024
9 of 10 checks passed
@hannibal002 hannibal002 deleted the fixnpemaybe branch February 29, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulonaut Lulonaut Lulonaut approved these changes

@hannibal002 hannibal002 hannibal002 approved these changes

@NopoTheGamer NopoTheGamer Awaiting requested review from NopoTheGamer

Assignees
No one assigned
Labels
bug-fix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nea89o @hannibal002 @Lulonaut @jani270