lib: replace type // { check = ...; } with v2-compatible patterns#1209
Merged
lib: replace type // { check = ...; } with v2-compatible patterns#1209
type // { check = ...; } with v2-compatible patterns#1209Conversation
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I37ded98877013bf232dfb8d575980de46a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: If5bf0e5f302afb9f7018b55a96109c006a6a6964
17 tasks
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I90ce0f42984ffbca9dfbdf4d97d2fc636a6a6964
Soliprem
approved these changes
Nov 2, 2025
Collaborator
the "typo" is from a release-note where the typo is fixed
|
mlambie
added a commit
to mlambie/nvf
that referenced
this pull request
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1207 by replacing ad-hoc type overrides that are incompatible with the new nixpkgs v2 merge mechanism with proper l
ib.types.addCheckandmkOptionTypepatterns.The nixpkgs v2 merge mechanism (introduced in NixOS/nixpkgs#391544) now throws errors when encountering
type // { check = ...;}patterns, as documented in NixOS/nixpkgs#454964. This affects our custom type definitions inlib/types/custom.nixandlib/types/dag.nix. We solve this by replacing patterns such assuper // { name = "..."; description = "..."; merge = ...; }with new ones.The changes should be fully backwards compatible, no changelog entry is warranted as the impact is fully internal. Tested with the NixOS module.
Signed-off-by: NotAShelf raf@notashelf.dev
Change-Id: I37ded98877013bf232dfb8d575980de46a6a6964