Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Background Tasks (Python3) #5

Closed
wants to merge 3 commits into from

Conversation

jeeftor
Copy link

@jeeftor jeeftor commented Apr 5, 2022

I made a few changes here mostly dealing with pickle / cpickle and how python3 handles strings. Local testing seems to fix some of the issues I was seeing - which in summary are the following:

  • Default CacheDIR wasn't being picked up by background process - so I just got rid of the Alfred 2 version and moved to the Alfred 4
  • There were issues with how strings were getting encoded relating to Python3 - removed string-specific logic and pickle now seems to handle them fine.

I also updated the pre-commit hooks to add Mypy - but realized thats WAY too much for this PR so its commented out.

Using these changes I got my emoji plugin downloading files again with reporting:

image

workflow/workflow.py Outdated Show resolved Hide resolved
@jeeftor
Copy link
Author

jeeftor commented Apr 5, 2022

I'm not fully sure how to get the testing suite up and running locally as of yet ...

@jeeftor
Copy link
Author

jeeftor commented Apr 5, 2022

I haven't managed to mess with the tox testing setup - but my emojitaco plugin is now working again with these changes ... so I'll call it a win :)

@jeeftor jeeftor changed the title fixing bg processing Fix Background Tasks (Python3) Apr 5, 2022
@NorthIsUp
Copy link
Owner

this looks like good work but the tests are unhappy for some reason now.

@jeeftor
Copy link
Author

jeeftor commented Apr 13, 2022

We're they passing before? I thought they weren't. I'm headed on vacation for 5 days. Can try to look when I return

@NorthIsUp
Copy link
Owner

NorthIsUp commented Apr 13, 2022 via email

@jeeftor jeeftor closed this Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants