Skip to content

fix(gpui): clip rounded media to visible bounds - #1

Merged
aronNormal merged 1 commit into
flowform/upstream-2026-07-14from
codex/gpui-media-clipping-20260716
Jul 17, 2026
Merged

fix(gpui): clip rounded media to visible bounds#1
aronNormal merged 1 commit into
flowform/upstream-2026-07-14from
codex/gpui-media-clipping-20260716

Conversation

@aronNormal

@aronNormal aronNormal commented Jul 16, 2026

Copy link
Copy Markdown

Summary

  • preserve caller-defined image boxes when both axes are constrained
  • add visible clip bounds for rounded image masking across Metal, WGSL, and HLSL
  • keep cover sampling/crop behavior aligned for images and surfaces

Verification

  • cargo fmt --all --check
  • git diff --check
  • cargo check -p gpui
  • cargo test -p gpui elements::img::tests (2 passed)
  • cargo test -p gpui cover (2 passed)
  • production-equivalent Flowform client build and visual acceptance

Context

Ports the narrow visible-clip approach from Zed PR zed-industries#59300 / issue zed-industries#44339 into
the Flowform GPUI fork. This is the first PR in the dependency stack.

@aronNormal
aronNormal marked this pull request as ready for review July 17, 2026 01:35
@aronNormal
aronNormal merged commit 6d43194 into flowform/upstream-2026-07-14 Jul 17, 2026
24 checks passed
@aronNormal
aronNormal deleted the codex/gpui-media-clipping-20260716 branch July 17, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant