This repository was archived by the owner on Apr 9, 2026. It is now read-only.
NCP2286: Upgrade to pc-ble-driver 4.1.0#217
Merged
alwa-nordic merged 16 commits intomasterfrom May 2, 2019
Merged
Conversation
bencefr
reviewed
Apr 12, 2019
bihanssen
reviewed
Apr 12, 2019
alwa-nordic
force-pushed
the
NCP-2286
branch
2 times, most recently
from
aa3dbc9 to
8eab402
Compare
kenr
reviewed
May 2, 2019
kenr
reviewed
May 2, 2019
Use find_package instead of submodule for pc-ble-driver, and remove said submodule. This also upgrades pc-ble-driver to 4.1.0. EnumSerialPorts from nrf-ble-driver has changed signature. It now returns a list instead of filling a provided one.
CMake install target will now install/update the connectivity firmware hex files from the nrf-ble-driver package in case it's old or missing. build.js now invokes the install target.
Macos has gained support for this. It is no longer necessary to limit it to 115k.
EnumSerialPorts is a private API. This change replaces its use with the public API sd_rpc_serial_port_enum.
Without this or a .npmignore, npm pack looks at .gitingore. .gitignore would prevent pc-ble-driver/ from inclusion. This also reduces size and file count of package.
Resolving grabAdapter promises concurrently results in a race, which
most of the time results in the error:
Error: Error occured when open device long term. Errorcode: CouldNotCallFunction (0x9)
Lowlevel error: INVALID_OPERATION (fffffffe)
When two nRF52 dongles need programming, the device setup can take about 40 seconds on my machine.
bencefr
previously approved these changes
May 2, 2019
Contributor
|
Nice job! |
These were mistakenly taken from an outdated document and don't reflect reality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhaul in conjunction with upgrading to pc-ble-driver 4.1.0. See commits for details.