Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #235 - Support aarch64 and non-GPU systems, tidy up gpuapi builds #236

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

lars-t-hansen
Copy link
Collaborator

@lars-t-hansen lars-t-hansen commented Jan 22, 2025

GPU API fixes:

  • Introduce subdirectories for architecture-specific gpuapi libraries
  • Make build.rs pick the right subdirectory
  • Introduce ifdefs in the gpuapi library sources to allow them to be compiled even if GPU API is unavailable
  • Introduce site and node specific build scripts for the libraries

Other aarch64 fixes:

  • /proc/cpuinfo is completely different, so parse it properly
  • cty::c_char is u8, so clean up the mess around C's char type

Feature system:

  • Add Cargo features for amd, nvidia, xpu to complement the stub libraries
  • Add a skeleton implementation of XPU that is not supposed to link yet (no libraries)
  • Add test cases for feature combinations

Also ran cargo fmt and picked up some random changes that way.

Also cleaned up the text in some test cases.

@lars-t-hansen lars-t-hansen requested a review from bast January 22, 2025 09:31
@lars-t-hansen lars-t-hansen mentioned this pull request Jan 22, 2025
@lars-t-hansen
Copy link
Collaborator Author

The test failure seems to be caused by the return of an old problem wherein the github runner environment is missing some environment variable that the tests depend on.

@lars-t-hansen
Copy link
Collaborator Author

Specifically, in #193 we fixed a regex so that user names could contain dashes, now we have a user name with a leading underscore.

@lars-t-hansen lars-t-hansen force-pushed the w-235-gpuapi-multiarch branch from d73b8ea to adcc700 Compare January 23, 2025 08:34
@bast
Copy link
Member

bast commented Jan 28, 2025

There is a conflict here - should I look at that?

@lars-t-hansen
Copy link
Collaborator Author

There is a conflict here - should I look at that?

If convenient, otherwise I'll deal with in the morning. If you're happy with the patch in other respects I can merge it myself, LMK.

@lars-t-hansen lars-t-hansen force-pushed the w-235-gpuapi-multiarch branch from adcc700 to 850e2d5 Compare January 29, 2025 07:19
@bast bast merged commit 1653a8c into NordicHPC:main Jan 29, 2025
2 checks passed
@bast
Copy link
Member

bast commented Jan 29, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants