Added support for BGR, BGR565, BGRA4444 and BGRA5551 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added RawEncoders for Bgr, Bgr565, Bgra4444 and Bgra5551 - Added tests for Bgr, Bgr565, Bgra4444 and Bgra5551 - Fixed DecodeInternal relying on dwMipMapCount being set correctly when DDS_HEADER_FLAGS_MIPMAP is not set.
DummkopfOfHachtenduden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for a bunch of BGR/A formats that I need for a project of mine. I've also fixed what I consider a bug where DecodeInternal relies on dwMipMapCount being set correctly when DDS_HEADER_FLAGS_MIPMAP is not set.
There is one rather weird case where I have an image that uses B5G5R5 but has no DdpfAlphaPixels flag and dwABitMask = 0. I'm not exactly sure how to go about this. Visual Studio detects this as B5G5R5A1. I'm doing the same but right now this results in a completely transparent image since the RawDecoder is missing context for this.