-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Move packages from v-next/ to packages/
#8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
54f09db
Rename the v-next folder to packages
alcuadrado 11776f4
Fix all package.json homepage fields
alcuadrado 37479ce
Fix package.json#repository.directory
alcuadrado bfc6c5f
Fix plugin links in README.md files
alcuadrado 8575e87
Fix link in ignition-core's README.md file
alcuadrado e7604d9
Update duplication warning between hardhat-utils and hardhat-node-tes…
alcuadrado e8206e5
Update comments
alcuadrado b886951
Update cspell config
alcuadrado 8b71777
Update pnpm workspace
alcuadrado 361d0c9
Update pnpm-lock.yaml
alcuadrado e329441
Update script: scripts/version-alpha.ts
alcuadrado 241f5db
Update script: scripts/check-npm-scripts.ts
alcuadrado 472d8ca
Update script: scripts/bump-peers.ts
alcuadrado c091399
Update script: scripts/check-dependencies.ts
alcuadrado b9487ae
Update script: scripts/github-release/file-helpers.ts
alcuadrado 093f66d
Update script: scripts/lib/packages.ts
alcuadrado e1bdcfa
Update script: scripts/verdaccio/publish.ts
alcuadrado 6491c32
Update hardhat test
alcuadrado eca506e
Update CLAUDE.md
alcuadrado a4fafd5
Update .peer-bumps.json
alcuadrado 4b5377f
Update .github/workflows/regression-tests.yml
alcuadrado fcae776
Update .github/workflows/release.yml
alcuadrado af0ef9f
Update .claude/commands/analyze-peer-bump.md
alcuadrado 2a42385
Rename .github/workflows/v-next-ci.yml to .github/workflows/ci.yml
alcuadrado e005ee4
ci.yml: Update is-v-next check
alcuadrado 7c7b7c4
ci.yml: change name
alcuadrado a183219
ci.yml: Update the actual workflow
alcuadrado 7fb721b
Add changesets
alcuadrado 60e0ddc
Correct casing of the NomicFoundation github url in the package.json …
alcuadrado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "hardhat": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "@nomicfoundation/ignition-core": patch | ||
| "@nomicfoundation/ignition-ui": patch | ||
| "@nomicfoundation/hardhat-ignition-ethers": patch | ||
| "@nomicfoundation/hardhat-ignition": patch | ||
| "@nomicfoundation/hardhat-ignition-viem": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-errors": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
5 changes: 5 additions & 0 deletions
5
.changeset/packages-nomicfoundation-hardhat-ethers-chai-matchers.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-ethers-chai-matchers": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-ethers": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-foundry": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-keystore": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-ledger": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-mocha": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
5 changes: 5 additions & 0 deletions
5
.changeset/packages-nomicfoundation-hardhat-network-helpers.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-network-helpers": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
5 changes: 5 additions & 0 deletions
5
.changeset/packages-nomicfoundation-hardhat-node-test-reporter.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-node-test-reporter": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
5 changes: 5 additions & 0 deletions
5
.changeset/packages-nomicfoundation-hardhat-node-test-runner.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-node-test-runner": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
5 changes: 5 additions & 0 deletions
5
.changeset/packages-nomicfoundation-hardhat-toolbox-mocha-ethers.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-toolbox-mocha-ethers": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-toolbox-viem": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-typechain": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-utils": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-vendored": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-verify": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
5 changes: 5 additions & 0 deletions
5
.changeset/packages-nomicfoundation-hardhat-viem-assertions.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-viem-assertions": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-viem": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nomicfoundation/hardhat-zod-utils": patch | ||
| --- | ||
|
|
||
| [chore] Move to packages/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| name: vNext CI | ||||||
| name: CI | ||||||
|
|
||||||
| on: | ||||||
| merge_group: | ||||||
|
|
@@ -14,23 +14,23 @@ concurrency: | |||||
| cancel-in-progress: true | ||||||
|
|
||||||
| jobs: | ||||||
| is-v-next: | ||||||
| is-v3: | ||||||
| runs-on: ubuntu-latest | ||||||
| outputs: | ||||||
| is_v_next: ${{ steps.check.outputs.folder_exists }} | ||||||
| is_v3: ${{ steps.check.outputs.version_starts_with_3 }} | ||||||
| scripts_changed: ${{ steps.scripts-filter.outputs.scripts }} | ||||||
|
|
||||||
| steps: | ||||||
| - name: Checkout code | ||||||
| uses: actions/checkout@v5 | ||||||
|
|
||||||
| - name: Check if the folder v-next exists | ||||||
| - name: Check if we are in v3 | ||||||
| id: check | ||||||
| run: | | ||||||
| if [ -d "./v-next" ]; then | ||||||
| echo "folder_exists=true" >> $GITHUB_OUTPUT | ||||||
| if jq -e '.version | startswith("3")' packages/hardhat/package.json > /dev/null; then | ||||||
|
||||||
| if jq -e '.version | startswith("3")' packages/hardhat/package.json > /dev/null; then | |
| if test -f packages/hardhat/package.json && jq -e '.version | startswith("3")' packages/hardhat/package.json > /dev/null 2>&1; then |
alcuadrado marked this conversation as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow’s gating is tied to
packages/hardhat/package.jsonhaving a version that starts with"3". This will silently disable downstream CI jobs (dependency checks, script tests, package matrix) as soon as the major version changes (e.g.,4.0.0), even though the repo layout (packages/) may still be the same. Consider gating on repository layout (e.g., existence of./packages/hardhat/package.jsonor./packagesdirectory) instead of a hard-coded major version, so CI continues to run reliably across future version bumps.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any idea how complex is to do a major release of Hardhat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementing a new Hardhat major - 2 weeks tops.