Skip to content

Fix #8013 #8014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alcuadrado merged 4 commits into from
Feb 28, 2026
Merged

Fix #8013 #8014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82d2647
Add an ignition-core regression test that fails when a library is dep…
alcuadrado Feb 27, 2026
c145369
Don't prepend the source name if it's already a FQN
alcuadrado Feb 27, 2026
3916293
Create clever-feet-trade.md
alcuadrado Feb 27, 2026
06a5833
Address review comment
alcuadrado Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-feet-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nomicfoundation/ignition-core": patch
---

Fix an issue that prevented the verification of contracts using FQNs [#8014](https://github.com/NomicFoundation/hardhat/pull/8014)
4 changes: 3 additions & 1 deletion v-next/ignition-core/src/verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ async function convertExStateToVerifyInfo(
constructorArgs,
libraries,
address: exState.result.address,
contract: `${artifact.sourceName}:${contractName}`,
contract: contractName.includes(":")
? contractName
: `${artifact.sourceName}:${contractName}`,
};

return verifyInfo;
Expand Down
1 change: 1 addition & 0 deletions v-next/ignition-core/test/mocks/verify/fqn-contract-name/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This mock deployment a library deployed with a FQN as contract name.
4 changes: 4 additions & 0 deletions v-next/ignition-core/test/mocks/verify/fqn-contract-name/artifacts/LockModule#UUUUU.dbg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"_format": "hh-sol-dbg-1",
"buildInfo": "../build-info/254cc89254e61cb6a9bf2c74f13055f1.json"
}
37 changes: 37 additions & 0 deletions v-next/ignition-core/test/mocks/verify/fqn-contract-name/artifacts/LockModule#UUUUU.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"_format": "hh-sol-artifact-1",
"contractName": "UUUUU",
"sourceName": "contracts/Lib.sol",
"abi": [
{
"anonymous": false,
"inputs": [
{
"indexed": false,
"internalType": "uint256",
"name": "bf",
"type": "uint256"
}
],
"name": "yu",
"type": "event"
},
{
"inputs": [],
"name": "cn",
"outputs": [
{
"internalType": "uint256",
"name": "",
"type": "uint256"
}
],
"stateMutability": "pure",
"type": "function"
}
],
"bytecode": "0x61023a610053600b82828239805160001a607314610046577f4e487b7100000000000000000000000000000000000000000000000000000000600052600060045260246000fd5b30600052607381538281f3fe73000000000000000000000000000000000000000030146080604052600436106100405760003560e01c8063856c67f414610045578063a3a79ad71461006e575b600080fd5b81801561005157600080fd5b5061006c60048036038101906100679190610120565b61008c565b005b6100766100d8565b604051610083919061015c565b60405180910390f35b7fbbd59f58682e05b023d29551eca4f8ef7fb7413f5dc80469ddef4d332586fd256100b56100d8565b826100c091906101a6565b6040516100cd91906101e9565b60405180910390a150565b6000641cbe86ba4d905090565b600080fd5b6000819050919050565b6100fd816100ea565b811461010857600080fd5b50565b60008135905061011a816100f4565b92915050565b600060208284031215610136576101356100e5565b5b60006101448482850161010b565b91505092915050565b610156816100ea565b82525050565b6000602082019050610171600083018461014d565b92915050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052601160045260246000fd5b60006101b1826100ea565b91506101bc836100ea565b92508282019050808211156101d4576101d3610177565b5b92915050565b6101e3816100ea565b82525050565b60006020820190506101fe60008301846101da565b9291505056fea2646970667358221220c15d1d30c7e4fcaa2bcd8092153ba13d28b770b6e90531af7317221cc4a474dd64736f6c63430008130033",
"deployedBytecode": "0x73000000000000000000000000000000000000000030146080604052600436106100405760003560e01c8063856c67f414610045578063a3a79ad71461006e575b600080fd5b81801561005157600080fd5b5061006c60048036038101906100679190610120565b61008c565b005b6100766100d8565b604051610083919061015c565b60405180910390f35b7fbbd59f58682e05b023d29551eca4f8ef7fb7413f5dc80469ddef4d332586fd256100b56100d8565b826100c091906101a6565b6040516100cd91906101e9565b60405180910390a150565b6000641cbe86ba4d905090565b600080fd5b6000819050919050565b6100fd816100ea565b811461010857600080fd5b50565b60008135905061011a816100f4565b92915050565b600060208284031215610136576101356100e5565b5b60006101448482850161010b565b91505092915050565b610156816100ea565b82525050565b6000602082019050610171600083018461014d565b92915050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052601160045260246000fd5b60006101b1826100ea565b91506101bc836100ea565b92508282019050808211156101d4576101d3610177565b5b92915050565b6101e3816100ea565b82525050565b60006020820190506101fe60008301846101da565b9291505056fea2646970667358221220c15d1d30c7e4fcaa2bcd8092153ba13d28b770b6e90531af7317221cc4a474dd64736f6c63430008130033",
"linkReferences": {},
"deployedLinkReferences": {}
}
4 changes: 4 additions & 0 deletions v-next/ignition-core/test/mocks/verify/fqn-contract-name/artifacts/LockModule#WAAIT.dbg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"_format": "hh-sol-dbg-1",
"buildInfo": "../build-info/254cc89254e61cb6a9bf2c74f13055f1.json"
}
29 changes: 29 additions & 0 deletions v-next/ignition-core/test/mocks/verify/fqn-contract-name/artifacts/LockModule#WAAIT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"_format": "hh-sol-artifact-1",
"contractName": "WAAIT",
"sourceName": "contracts/Lock.sol",
"abi": [
{
"inputs": [],
"stateMutability": "nonpayable",
"type": "constructor"
}
],
"bytecode": "0x608060405234801561001057600080fd5b5073__$e1bfcf6041ff8ba6df21245bab8ae07a55$__63856c67f473__$e1bfcf6041ff8ba6df21245bab8ae07a55$__63a3a79ad76040518163ffffffff1660e01b8152600401602060405180830381865af4158015610074573d6000803e3d6000fd5b505050506040513d601f19601f820116820180604052508101906100989190610124565b6040518263ffffffff1660e01b81526004016100b49190610160565b60006040518083038186803b1580156100cc57600080fd5b505af41580156100e0573d6000803e3d6000fd5b5050505061017b565b600080fd5b6000819050919050565b610101816100ee565b811461010c57600080fd5b50565b60008151905061011e816100f8565b92915050565b60006020828403121561013a576101396100e9565b5b60006101488482850161010f565b91505092915050565b61015a816100ee565b82525050565b60006020820190506101756000830184610151565b92915050565b603f806101896000396000f3fe6080604052600080fdfea2646970667358221220cb2ee4f824d599c1f160d9867571f972f7aaf7ab2f13b22e78324469179161ce64736f6c63430008130033",
"deployedBytecode": "0x6080604052600080fdfea2646970667358221220cb2ee4f824d599c1f160d9867571f972f7aaf7ab2f13b22e78324469179161ce64736f6c63430008130033",
"linkReferences": {
"contracts/Lib.sol": {
"UUUUU": [
{
"length": 20,
"start": 19
},
{
"length": 20,
"start": 45
}
]
}
},
"deployedLinkReferences": {}
}
Loading