fix(ignition): Pass global config to Ignition helper implementations

.changeset/changeset_pass-config-to-ignition-helpers.md

@@ -0,0 +1,6 @@
+---
+"@nomicfoundation/hardhat-ignition-ethers": patch
+"@nomicfoundation/hardhat-ignition-viem": patch
+---
+
+Fixed a bug preventing Ignition from using the `hre.config.ignition` settings when deploying via script ([#7641](https://github.com/NomicFoundation/hardhat/issues/7641))

v-next/hardhat-ignition-ethers/.gitignore

@@ -142,3 +142,6 @@ dist
 
 # npm lockfile since we use pnpm now
 package-lock.json
+
+artifacts
+cache

v-next/hardhat-ignition-ethers/src/internal/ethers-ignition-helper.ts

@@ -134,10 +134,8 @@ export class EthersIgnitionHelperImpl<ChainTypeT extends ChainType | string>
         this.#artifactsManager,
       );
 
-      const resolvedConfig: Partial<DeployConfig> = {
-        ...this.#config,
-        ...perDeployConfig,
-      };
+      const resolvedConfig: Partial<DeployConfig> =
+        this.getResolvedConfig(perDeployConfig);
 
       const resolvedStrategyConfig = this.#resolveStrategyConfig<StrategyT>(
         this.#hardhatConfig,
@@ -213,6 +211,15 @@ export class EthersIgnitionHelperImpl<ChainTypeT extends ChainType | string>
     }
   }
 
+  public getResolvedConfig(
+    perDeployConfig: Partial<DeployConfig>,
+  ): Partial<DeployConfig> {
+    return {
+      ...this.#config,
+      ...perDeployConfig,
+    };
+  }
+
   async #toEthersContracts<
     ModuleIdT extends string,
     ContractNameT extends string,

v-next/hardhat-ignition-ethers/src/internal/hook-handlers/network.ts

@@ -25,6 +25,7 @@ export default async (): Promise<Partial<NetworkHooks>> => {
         context.config,
         context.artifacts,
         connection,
+        context.config.ignition,
       );
 
       return connection;

v-next/hardhat-ignition-ethers/src/types.ts

@@ -38,6 +38,10 @@ export interface EthersIgnitionHelper {
       IgnitionModuleResultsT
     >
   >;
+
+  getResolvedConfig(
+    perDeployConfig: Partial<DeployConfig>,
+  ): Partial<DeployConfig>;
 }
 
 export type IgnitionModuleResultsTToEthersContracts<

v-next/hardhat-ignition-ethers/test/config.ts

@@ -0,0 +1,22 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+
+import { useEphemeralFixtureProject } from "@nomicfoundation/hardhat-test-utils";
+
+import { createConnection } from "./test-helpers/create-hre.js";
+import "@nomicfoundation/hardhat-ethers";
+
+describe("config", () => {
+  useEphemeralFixtureProject("config");
+
+  it("should resolve config in the correct priority", async function () {
+    const connection = await createConnection();
+
+    const resolvedConfig = connection.ignition.getResolvedConfig({
+      maxFeeBumps: 7,
+    });
+
+    assert.equal(resolvedConfig.requiredConfirmations, 42);
+    assert.equal(resolvedConfig.maxFeeBumps, 7);
+  });
+});

v-next/hardhat-ignition-ethers/test/fixture-projects/config/hardhat.config.js

@@ -0,0 +1,14 @@
+export default {
+  solidity: "0.8.19",
+  networks: {
+    default: {
+      mining: {
+        auto: false,
+      },
+    },
+  },
+  ignition: {
+    requiredConfirmations: 42,
+    maxFeeBumps: 1234,
+  },
+};

v-next/hardhat-ignition-viem/.gitignore

@@ -142,3 +142,6 @@ dist
 
 # npm lockfile since we use pnpm now
 package-lock.json
+
+artifacts
+cache

v-next/hardhat-ignition-viem/src/internal/hook-handlers/network.ts

@@ -25,6 +25,7 @@ export default async (): Promise<Partial<NetworkHooks>> => {
         context.config,
         context.artifacts,
         connection,
+        context.config.ignition,
       );
 
       return connection;

v-next/hardhat-ignition-viem/src/internal/viem-ignition-helper.ts

@@ -136,10 +136,8 @@ export class ViemIgnitionHelperImpl<ChainTypeT extends ChainType | string>
         this.#artifactsManager,
       );
 
-      const resolvedConfig: Partial<DeployConfig> = {
-        ...this.#config,
-        ...perDeployConfig,
-      };
+      const resolvedConfig: Partial<DeployConfig> =
+        this.getResolvedConfig(perDeployConfig);
 
       const resolvedStrategyConfig =
         ViemIgnitionHelperImpl.#resolveStrategyConfig<StrategyT>(
@@ -216,6 +214,15 @@ export class ViemIgnitionHelperImpl<ChainTypeT extends ChainType | string>
     }
   }
 
+  public getResolvedConfig(
+    perDeployConfig: Partial<DeployConfig>,
+  ): Partial<DeployConfig> {
+    return {
+      ...this.#config,
+      ...perDeployConfig,
+    };
+  }
+
   async #toViemContracts<
     ModuleIdT extends string,
     ContractNameT extends string,

v-next/hardhat-ignition-viem/src/types.ts

@@ -39,6 +39,10 @@ export interface ViemIgnitionHelper {
   ): Promise<
     IgnitionModuleResultsToViemContracts<ContractNameT, IgnitionModuleResultsT>
   >;
+
+  getResolvedConfig(
+    perDeployConfig: Partial<DeployConfig>,
+  ): Partial<DeployConfig>;
 }
 
 export type IgnitionModuleResultsToViemContracts<

v-next/hardhat-ignition-viem/test/config.ts

@@ -0,0 +1,22 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+
+import { useEphemeralFixtureProject } from "@nomicfoundation/hardhat-test-utils";
+
+import { createConnection } from "./test-helpers/create-hre.js";
+import "@nomicfoundation/hardhat-viem";
+
+describe("config", () => {
+  useEphemeralFixtureProject("config");
+
+  it("should resolve config in the correct priority", async function () {
+    const connection = await createConnection();
+
+    const resolvedConfig = connection.ignition.getResolvedConfig({
+      maxFeeBumps: 7,
+    });
+
+    assert.equal(resolvedConfig.requiredConfirmations, 42);
+    assert.equal(resolvedConfig.maxFeeBumps, 7);
+  });
+});

v-next/hardhat-ignition-viem/test/fixture-projects/config/hardhat.config.js

@@ -0,0 +1,14 @@
+export default {
+  solidity: "0.8.19",
+  networks: {
+    default: {
+      mining: {
+        auto: false,
+      },
+    },
+  },
+  ignition: {
+    requiredConfirmations: 42,
+    maxFeeBumps: 1234,
+  },
+};