Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ inputs:
node-version:
description: Version of node to install
required: false
default: "22"
default: "24"
cache-save:
description: Whether to save the pnpm cache
required: false
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/v-next-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
- name: Run check
run: node scripts/check-v-next-dependencies.js

Expand All @@ -53,7 +53,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
- name: Run check
run: node scripts/check-v-next-npm-scripts.js

Expand All @@ -69,7 +69,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
- run: yq -p yaml -o json pnpm-lock.yaml | tee pnpm-lock.json
- id: generate
env:
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-env
with:
node-version: 22
node-version: 24
- name: Install dependencies
run: pnpm install --frozen-lockfile --prefer-offline
- name: Build
Expand Down Expand Up @@ -206,7 +206,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-env
with:
node-version: 22
node-version: 24
- name: Install dependencies
run: pnpm install --frozen-lockfile --prefer-offline
- name: Build
Expand Down Expand Up @@ -241,7 +241,7 @@ jobs:
matrix:
package: ${{ fromJson(needs.list-packages.outputs.packages) }}
os: [ubuntu-latest, macos-13, macos-latest, windows-latest]
node: [22]
node: [22, 24]

name: "[${{ matrix.package }}] ci on ${{ matrix.os }} (Node ${{ matrix.node }})"
runs-on: ${{ matrix.os }}
Expand Down
4 changes: 3 additions & 1 deletion v-next/config/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,9 @@ export function createConfig(
"Don't import from the src folder, use the package entry point instead.",
},
{
group: builtinModules.map((m) => `/${m}`),
group: builtinModules
.filter((m) => !m.startsWith("node:"))
.map((m) => `/${m}`),
message:
"Use the 'node:' prefix to import built-in Node.js modules.",
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This folder contains integration tests for the reporter. They don't use `node:test` as driver of the test runs, as you can't run `node:test` within `node:test`.

Instead, the script `index.ts` runs all the tests in each fixture folder, comparing the reporter's results with `result.txt`.
Instead, the script `index.ts` runs all the tests in each fixture folder, comparing the reporter's results with `result.$NODE_MAJOR_VERSION.txt` (or `result.txt` as a fallback if a node-specific result file does not exist).

## Running all tests

Expand Down

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
7) level 0


3 passing (132ms)
3 passing (140ms)
7 failing
1 cancelled

Expand Down Expand Up @@ -64,9 +64,9 @@
+ 1

 at TestContext.<anonymous> (integration-tests/fixture-tests/nested-test/test.ts:29:22)
 at Test.runInAsyncScope (node:async_hooks:211:14)
 at Test.run (node:internal/test_runner/test:979:25)
 at Test.start (node:internal/test_runner/test:877:17)
 at Test.runInAsyncScope (node:async_hooks:214:14)
 at Test.run (node:internal/test_runner/test:1047:25)
 at Test.start (node:internal/test_runner/test:944:17)
 at startSubtestAfterBootstrap (node:internal/test_runner/harness:296:17)
 at run (node:internal/test_runner/harness:307:12)
 at test (node:internal/test_runner/harness:316:12)
Expand All @@ -82,18 +82,18 @@

Error: error with cause
 at TestContext.<anonymous> (integration-tests/fixture-tests/nested-test/test.ts:33:21)
 at Test.runInAsyncScope (node:async_hooks:211:14)
 at Test.run (node:internal/test_runner/test:979:25)
 at Test.start (node:internal/test_runner/test:877:17)
 at Test.runInAsyncScope (node:async_hooks:214:14)
 at Test.run (node:internal/test_runner/test:1047:25)
 at Test.start (node:internal/test_runner/test:944:17)
 at startSubtestAfterBootstrap (node:internal/test_runner/harness:296:17)
 at run (node:internal/test_runner/harness:307:12)
 at test (node:internal/test_runner/harness:316:12)
 at TestContext.<anonymous> (integration-tests/fixture-tests/nested-test/test.ts:32:19)
[cause]: Error: cause
 at TestContext.<anonymous> (integration-tests/fixture-tests/nested-test/test.ts:34:24)
 at Test.runInAsyncScope (node:async_hooks:211:14)
 at Test.run (node:internal/test_runner/test:979:25)
 at Test.start (node:internal/test_runner/test:877:17)
 at Test.runInAsyncScope (node:async_hooks:214:14)
 at Test.run (node:internal/test_runner/test:1047:25)
 at Test.start (node:internal/test_runner/test:944:17)
 at startSubtestAfterBootstrap (node:internal/test_runner/harness:296:17)
 at run (node:internal/test_runner/harness:307:12)
 at test (node:internal/test_runner/harness:316:12)
Expand Down
Loading
Loading