Fix hardcoded URL in the etherscan plugin

NomicFoundation · Mar 1, 2023 · 6ecb74d · 6ecb74d
1 parent e51bb21
commit 6ecb74d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/packages/hardhat-etherscan/src/etherscan/EtherscanService.ts b/packages/hardhat-etherscan/src/etherscan/EtherscanService.ts
@@ -156,12 +156,21 @@ export class EtherscanResponse {
 }
 
 export async function isAlreadyVerified(
+  apiURL: string,
   apiKey: string,
   address: string
 ): Promise<boolean> {
-  const url = `https://api.etherscan.io/api?module=contract&action=getsourcecode&address=${address}&apikey=${apiKey}`;
+  const parameters = new URLSearchParams({
+    module: "contract",
+    action: "getsourcecode",
+    address,
+    apikey: apiKey,
+  });
 
-  const response = await sendGetRequest(new URL(url));
+  const url = new URL(apiURL);
+  url.search = parameters.toString();
+
+  const response = await sendGetRequest(url);
   const json = await response.body.json();
 
   if (json.message !== "OK") {

diff --git a/packages/hardhat-etherscan/src/index.ts b/packages/hardhat-etherscan/src/index.ts
@@ -225,7 +225,13 @@ If your constructor has no arguments pass an empty array. E.g:
     verificationNetwork
   );
 
-  if (await isAlreadyVerified(etherscanAPIKey, address)) {
+  const alreadyVerified = await isAlreadyVerified(
+    etherscanAPIEndpoints.apiURL,
+    etherscanAPIKey,
+    address
+  );
+
+  if (alreadyVerified) {
     console.log(`The contract ${address} has already been verified`);
     return;
   }