Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions litellm/proxy/guardrails/guardrail_hooks/noma/noma_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import enum
import json
import os
from copy import deepcopy
from datetime import datetime
from typing import TYPE_CHECKING, Any, Literal, Optional, Type, cast
from urllib.parse import urlparse
Expand Down Expand Up @@ -139,7 +138,7 @@ def _build_scan_payload(
logging_obj: Optional["LiteLLMLoggingObj"],
application_id: Optional[str],
) -> dict:
payload_request_data = deepcopy(request_data)
payload_request_data = self._sanitize_payload_for_transport(request_data)
if logging_obj is not None:
payload_request_data["litellm_logging_obj"] = getattr(
logging_obj, "model_call_details", None
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,44 @@ def test_build_scan_payload_deep_copies_request_data(self, noma_v2_guardrail):
)
assert request_data["messages"][0]["content"] == "hello"

def test_build_scan_payload_survives_unpicklable_request_data(
self, noma_v2_guardrail
):
"""Regression test for NOM-8044: post_call / during_call / during_mcp_call
used to 500 because request_data contained uvloop.Loop and similar
C-extension objects whose __reduce__ raises, which crashed deepcopy."""

class _FakeUvloopObject:
def __reduce__(self):
raise TypeError("no default __reduce__ due to non-trivial __cinit__")

def __repr__(self) -> str:
return "<fake-uvloop-loop>"

unpicklable = _FakeUvloopObject()
request_data = {
"metadata": {"headers": {"x-noma-application-id": "header-app"}},
"messages": [{"role": "user", "content": "hello"}],
"event_loop": unpicklable,
}

payload = noma_v2_guardrail._build_scan_payload(
inputs={"texts": ["hello"]},
request_data=request_data,
input_type="response",
logging_obj=None,
application_id="dynamic-app",
)

assert isinstance(payload["request_data"], dict)
assert payload["request_data"]["event_loop"] == "<fake-uvloop-loop>"
assert payload["request_data"]["messages"] == [
{"role": "user", "content": "hello"}
]

# Original request_data must not have been mutated by the copy.
assert request_data["event_loop"] is unpicklable

def test_build_scan_payload_passes_model_call_details_as_is(
self, noma_v2_guardrail
):
Expand Down
Loading