Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user api #114

Merged
merged 3 commits into from
Dec 12, 2023
Merged

user api #114

merged 3 commits into from
Dec 12, 2023

Conversation

kishore881
Copy link
Contributor

PR for Issue #112

PierreDemailly
PierreDemailly reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@PierreDemailly PierreDemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else lgtm 👍

src/api/user.ts Outdated Show resolved Hide resolved
src/api/user.ts Outdated Show resolved Hide resolved
test/api.spec.ts Outdated Show resolved Hide resolved
@PierreDemailly
Copy link
Member

Can you also add documentation please ?

@PierreDemailly PierreDemailly merged commit ec44f90 into NodeSecure:main Dec 12, 2023
5 checks passed
@PierreDemailly
Copy link
Member

@all-contributors please add @kishore881 for code, test, doc

@allcontributors allcontributors bot mentioned this pull request Dec 12, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@PierreDemailly

I've put up a pull request to add @kishore881! 🎉

@kishore881 kishore881 deleted the user_api branch December 12, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreDemailly PierreDemailly PierreDemailly approved these changes

@fraxken fraxken fraxken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishore881 @PierreDemailly @fraxken