Switch from esmock to node.js mock tracker #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @albertshay888, can you remove the tests commented (what you migrated) ? Thanks |
fraxken
reviewed
Jan 10, 2025
|
Also, you don't need to do dynamic imports after mocking, you can drop these and import what needs to be tested classically at the top of the file. |
…js and added the imports at the top of each file
There was a problem hiding this comment.
You can also uninstall esmock (npm un esmock) and change the test script from
glob -c \"node --loader=esmock --no-warnings --test-concurrency 1 --test\" \"test/**/*.test.js\"
to
glob -c \"node --test-concurrency 1 --test\" \"test/**/*.test.js\"
Note that there are little conflicts, you can sync your fork and rebase with the main branch
Comment on lines
+102
to
+113
| // test("should retrieve repository whithin git config", async() => { | ||
| // const testingModule = await esmock("../../src/commands/scorecard.js", { | ||
| // fs: { | ||
| // readFileSync: () => [ | ||
| // "[remote \"origin\"]", | ||
| // "\turl = [email protected]:myawesome/repository.git" | ||
| // ].join("\n") | ||
| // } | ||
| // }); | ||
|
|
||
| // assert.deepEqual(testingModule.getCurrentRepository(), Ok(["myawesome/repository", "github"])); | ||
| // }); |
There was a problem hiding this comment.
Suggested change
| // test("should retrieve repository whithin git config", async() => { | |
| // const testingModule = await esmock("../../src/commands/scorecard.js", { | |
| // fs: { | |
| // readFileSync: () => [ | |
| // "[remote \"origin\"]", | |
| // "\turl = [email protected]:myawesome/repository.git" | |
| // ].join("\n") | |
| // } | |
| // }); | |
| // assert.deepEqual(testingModule.getCurrentRepository(), Ok(["myawesome/repository", "github"])); | |
| // }); |
Comment on lines
+130
to
+140
| // test("should not find origin remote", async() => { | ||
| // const testingModule = await esmock("../../src/commands/scorecard.js", { | ||
| // fs: { | ||
| // readFileSync: () => "just one line" | ||
| // } | ||
| // }); | ||
| // const result = testingModule.getCurrentRepository(); | ||
|
|
||
| // assert.equal(result.err, true); | ||
| // assert.equal(result.val, "Cannot find origin remote."); | ||
| // }); |
There was a problem hiding this comment.
Suggested change
| // test("should not find origin remote", async() => { | |
| // const testingModule = await esmock("../../src/commands/scorecard.js", { | |
| // fs: { | |
| // readFileSync: () => "just one line" | |
| // } | |
| // }); | |
| // const result = testingModule.getCurrentRepository(); | |
| // assert.equal(result.err, true); | |
| // assert.equal(result.val, "Cannot find origin remote."); | |
| // }); |
| }); | ||
|
|
||
| readFileSyncMock.mock.restoreAll(); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| }); | |
| }); | |
|
|
||
| // Require Internal Dependencies | ||
| import { buildServer } from "../src/http-server/index.js"; | ||
| import { CACHE_PATH } from "../src/http-server/cache.js"; | ||
| import * as rootModule from "../src/http-server/endpoints/root.js"; | ||
| import * as flagsModule from "../src/http-server/endpoints/flags.js"; | ||
| import * as indexModule from "../src/http-server/index.js"; |
There was a problem hiding this comment.
Suggested change
| import * as indexModule from "../src/http-server/index.js"; |
There is already the import { buildServer } from "../src/http-server/index.js";
So you can use buildServer() instead of indexModule.buildServer()
| }); | ||
|
|
||
| after(async() => { | ||
| after(async () => { |
There was a problem hiding this comment.
Suggested change
| after(async () => { | |
| after(async() => { |
Make sure you have the linter configured in your IDE, you can also run npm run lint-fix (there are some lint errors in the code)
Comment on lines
+88
to
+103
| // test("'/' should fail", async() => { | ||
| // const errors = []; | ||
| // const module = await esmock("../src/http-server/endpoints/root.js", { | ||
| // "@polka/send-type": { | ||
| // default: (res, status, { error }) => errors.push(error) | ||
| // } | ||
| // }); | ||
|
|
||
|
|
||
| // await module.get({}, ({ | ||
| // writeHead: () => { | ||
| // throw new Error("fake error"); | ||
| // } | ||
| // })); | ||
| // assert.deepEqual(errors, ["fake error"]); | ||
| // }); |
There was a problem hiding this comment.
Suggested change
| // test("'/' should fail", async() => { | |
| // const errors = []; | |
| // const module = await esmock("../src/http-server/endpoints/root.js", { | |
| // "@polka/send-type": { | |
| // default: (res, status, { error }) => errors.push(error) | |
| // } | |
| // }); | |
| // await module.get({}, ({ | |
| // writeHead: () => { | |
| // throw new Error("fake error"); | |
| // } | |
| // })); | |
| // assert.deepEqual(errors, ["fake error"]); | |
| // }); |
Comment on lines
+144
to
+158
| // test("'/flags/description/:title' should fail", async() => { | ||
| // const module = await esmock("../src/http-server/endpoints/flags.js", { | ||
| // stream: { | ||
| // pipeline: (stream, res, err) => err("fake error") | ||
| // }, | ||
| // fs: { | ||
| // createReadStream: () => "foo" | ||
| // } | ||
| // }); | ||
| // const logs = []; | ||
| // console.error = (data) => logs.push(data); | ||
|
|
||
| // await module.get({ params: { title: "hasWarnings" } }, ({ writeHead: () => true })); | ||
| // assert.deepEqual(logs, ["fake error"]); | ||
| // }); |
There was a problem hiding this comment.
Suggested change
| // test("'/flags/description/:title' should fail", async() => { | |
| // const module = await esmock("../src/http-server/endpoints/flags.js", { | |
| // stream: { | |
| // pipeline: (stream, res, err) => err("fake error") | |
| // }, | |
| // fs: { | |
| // createReadStream: () => "foo" | |
| // } | |
| // }); | |
| // const logs = []; | |
| // console.error = (data) => logs.push(data); | |
| // await module.get({ params: { title: "hasWarnings" } }, ({ writeHead: () => true })); | |
| // assert.deepEqual(logs, ["fake error"]); | |
| // }); |
Comment on lines
+356
to
+383
| // describe("httpServer without options", () => { | ||
| // let httpServer; | ||
| // let opened = false; | ||
| // // We want to disable WS | ||
| // process.env.NODE_ENV = "test"; | ||
|
|
||
| // before(async() => { | ||
| // const module = await esmock("../src/http-server/index.js", { | ||
| // open: () => (opened = true) | ||
| // }); | ||
|
|
||
| // httpServer = module.buildServer(JSON_PATH); | ||
| // await once(httpServer.server, "listening"); | ||
| // enableDestroy(httpServer.server); | ||
| // }); | ||
|
|
||
| // after(async() => { | ||
| // httpServer.server.destroy(); | ||
| // }); | ||
|
|
||
| // test("should listen on random port", () => { | ||
| // assert.ok(httpServer.server.address().port > 0); | ||
| // }); | ||
|
|
||
| // test("should have openLink to true", () => { | ||
| // assert.equal(opened, true); | ||
| // }); | ||
| // }); |
There was a problem hiding this comment.
Suggested change
| // describe("httpServer without options", () => { | |
| // let httpServer; | |
| // let opened = false; | |
| // // We want to disable WS | |
| // process.env.NODE_ENV = "test"; | |
| // before(async() => { | |
| // const module = await esmock("../src/http-server/index.js", { | |
| // open: () => (opened = true) | |
| // }); | |
| // httpServer = module.buildServer(JSON_PATH); | |
| // await once(httpServer.server, "listening"); | |
| // enableDestroy(httpServer.server); | |
| // }); | |
| // after(async() => { | |
| // httpServer.server.destroy(); | |
| // }); | |
| // test("should listen on random port", () => { | |
| // assert.ok(httpServer.server.address().port > 0); | |
| // }); | |
| // test("should have openLink to true", () => { | |
| // assert.equal(opened, true); | |
| // }); | |
| // }); |
Comment on lines
+413
to
+414
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converted all tests that uses esmock to Node.js MockTracker