forked from pingdotgg/t3code
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(fork): tighten composer chrome and ship green-grid favicon #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
357e4d8
feat(fork): tighten composer chrome and ship green-grid favicon
NoahHendrickson 1f5e93e
fix(fork): reuse shared web-icon brand apply path
NoahHendrickson f646c6a
fix(fork): split composer compact knobs and record brand carve-outs
NoahHendrickson d938873
docs(fork): add PR #46 before/after captures
NoahHendrickson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Fork shadow of upstream composerFooterLayout — see | ||
| // `.fork/customizations.yaml#fork-composer-shell`. | ||
| // | ||
| // Upstream's 620/780 thresholds were calibrated for packing mode + model into | ||
| // one in-box footer. The fork's denser below-surface control row (20px chips, | ||
| // text-only mode toggles, model on the opposite side) still has room well | ||
| // below those widths, so the ⋯ menu was firing with a large empty gap. Keep | ||
| // the wide-actions threshold under the form's max-w-3xl (768px) so the | ||
| // expanded row remains reachable at the form's natural ceiling. | ||
|
|
||
| export const COMPOSER_FOOTER_COMPACT_BREAKPOINT_PX = 400; | ||
| export const COMPOSER_FOOTER_WIDE_ACTIONS_COMPACT_BREAKPOINT_PX = 520; | ||
| export const COMPOSER_PRIMARY_ACTIONS_COMPACT_BREAKPOINT_PX = | ||
| COMPOSER_FOOTER_WIDE_ACTIONS_COMPACT_BREAKPOINT_PX; | ||
|
|
||
| export function shouldUseCompactComposerFooter( | ||
| width: number | null, | ||
| options?: { hasWideActions?: boolean }, | ||
| ): boolean { | ||
| const breakpoint = options?.hasWideActions | ||
| ? COMPOSER_FOOTER_WIDE_ACTIONS_COMPACT_BREAKPOINT_PX | ||
| : COMPOSER_FOOTER_COMPACT_BREAKPOINT_PX; | ||
| return width !== null && width < breakpoint; | ||
| } | ||
|
|
||
| export function shouldUseCompactComposerPrimaryActions( | ||
| width: number | null, | ||
| options?: { hasWideActions?: boolean }, | ||
| ): boolean { | ||
| if (!options?.hasWideActions) { | ||
| return false; | ||
| } | ||
| return width !== null && width < COMPOSER_PRIMARY_ACTIONS_COMPACT_BREAKPOINT_PX; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.