Support Elm 0.19 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Punie I have opened a PR in your fork that also fixes the tests for this branch: https://github.com/Punie/find-elm-dependencies/pull/1 |
|
@hecrj Thank you ! I merged it just now :) |
halfzebra
reviewed
Aug 27, 2018
| function getElmPackageSourceDirectories(baseDir, currentDir) { | ||
| if (typeof currentDir === "undefined") { | ||
| baseDir = path.resolve(baseDir); | ||
| currentDir = baseDir; | ||
| } | ||
|
|
||
| var elmPackagePath = path.join(currentDir, 'elm-package.json'); | ||
| var elmPackagePath = path.join(currentDir, 'elm.json'); |
There was a problem hiding this comment.
Not really elmPackagePath anymore, isn't it more like elmJsonPath?
There was a problem hiding this comment.
I guess it's still the file that defines the packages on which the elm build depends.
I'm happy to make the change to elmJsonPath if this terminology seems more sensible :)
|
Looks good to me. @stoeffel / @rtfeldman can you merge and release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I made a small change to support Elm 0.19 (by locating
elm.jsoninstead ofelm-package.json).As far as I know, other than this filename change, there were no fundamental differences on how modules and imports are resolved in 0.19.
This upgrade is necessary for
node-elm-compilerandelm-webpack-loaderto support Elm 0.19 (PR #142 on elm-webpack-loader)