This repository has been archived by the owner on May 17, 2019. It is now read-only.
Address CVE-2018-18074 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were dependent on the requests library version 2.12.0, which is vulnerable to CVE-2018-18074. This upgrades us to a version with a fix. I regenerated the `requirements.txt` file by running the `pip-compile` command it mentioned. This did not result in any changes, so I removed the file, then reran the command. This time multiple changes were made, including an upgrade of the `requests` package to a safe version.
jwoudenberg
changed the title
ento
approved these changes
Jan 21, 2019
| @@ -4,4 +4,8 @@ | |||
| # | |||
| # pip-compile --output-file requirements.txt requirements.in | |||
There was a problem hiding this comment.
To update, run:
I think this is actually saying "To update this file after making a change to requirements.in, run:"
There's a separate command for upgrading the version of a specific package: https://github.com/jazzband/pip-tools#updating-requirements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Fixes CVE-2018-18074.
Review asks
I followed instructions in the
requirements.txtfile for upgrading (see commit message). Please let me know if I should have done something else (entirely possible, I have little python experience!).