Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Fix argument order #24

Merged
merged 2 commits into from
Jul 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elm_package.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def sync_deps(from_deps, to_deps):
elif to_deps[package_name] != package_version:
result[package_name] = package_version

messages.append('Changing {package_name} from version {package_version} to {other_package_version}'.format(
messages.append('Changing {package_name} from version {other_package_version} to {package_version}'.format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

package_version=package_version, package_name=package_name,
other_package_version=to_deps[package_name])
)
Expand Down
10 changes: 10 additions & 0 deletions tests/test_elm_package.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import elm_package


def test_sync_deps_messages_when_version_is_changed():
from_deps = {'core': '1.0.0'}
to_deps = {'core': '0.1.0'}

messages, new_deps = elm_package.sync_deps(from_deps, to_deps)
assert len(messages) == 1
assert '0.1.0 to 1.0.0' in messages[0]