-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schemas #17
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
<h1>LOG</h1> | ||
<form action="/user" method="POST"></form> | ||
<label for="Exercise">Exercise</label> | ||
<select name="Exercise"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
// workoutlog data... connects to "user" page | ||
const express = require('express'); | ||
|
||
const router = express.Router(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
const router = express.Router(); | |
const workoutCtrl = require("../controllers/workoutlog"); |
@@ -1,9 +1,22 @@ | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
<<<<<<< HEAD | |
const logReps = require("../models/reps"); |
function index(req, res) { | ||
Log.find({}, function (err, workoutlog) { | ||
res.render('user/index'); | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Unnecessary semicolon.
}) | |
} |
|
||
// module.exports = { | ||
// index, | ||
// }; | ||
|
||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Unnecessary semicolon.
<<<<<<< HEAD | |
} |
const express = require('express'); | ||
const router = express.Router(); | ||
const durationCtrl = require('../controllers/duration'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
router.get("/", durationCtrl.index); |
@@ -1,10 +1,28 @@ | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
<<<<<<< HEAD | |
const logDuration = require("../models/duration"); |
<<<<<<< HEAD | ||
|
||
|
||
// GET and POST will go here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
// GET and POST will go here | |
router.get("/", repsCtrl.index); |
|
||
|
||
function index(req, res) { | ||
Log.find({}, function (err, workoutlog) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
Log.find({}, function (err, workoutlog) { | |
res.render("user/index"); |
@@ -1,3 +1,13 @@ | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
<<<<<<< HEAD | |
const express = require("express"); |
|
||
// module.exports = { | ||
// index, | ||
// }; | ||
|
||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Unnecessary semicolon.
<<<<<<< HEAD | |
} |
@@ -1,3 +1,13 @@ | |||
<<<<<<< HEAD | |||
const express = require('express'); | |||
const router = express.Router(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
const router = express.Router(); | |
const durationCtrl = require("../controllers/duration"); |
@@ -1,3 +1,22 @@ | |||
<<<<<<< HEAD | |||
// workoutlog data... connects to "user" page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
// workoutlog data... connects to "user" page | |
const express = require("express"); |
@@ -1,3 +1,19 @@ | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
<<<<<<< HEAD | |
const Log = require("../models/workoutlog"); |
No description provided.