Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Schemas #17

wants to merge 3 commits into from

Conversation

Nlopez4
Copy link
Owner

@Nlopez4 Nlopez4 commented Jul 31, 2021

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<h1>LOG</h1>
<form action="/user" method="POST"></form>
<label for="Exercise">Exercise</label>
<select name="Exercise">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

// workoutlog data... connects to "user" page
const express = require('express');

const router = express.Router();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
const router = express.Router();
const workoutCtrl = require("../controllers/workoutlog");

@@ -1,9 +1,22 @@
<<<<<<< HEAD
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
<<<<<<< HEAD
const logReps = require("../models/reps");

function index(req, res) {
Log.find({}, function (err, workoutlog) {
res.render('user/index');
})
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Unnecessary semicolon.

Suggested change
})
}


// module.exports = {
// index,
// };

<<<<<<< HEAD
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Unnecessary semicolon.

Suggested change
<<<<<<< HEAD
}

const express = require('express');
const router = express.Router();
const durationCtrl = require('../controllers/duration');

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
router.get("/", durationCtrl.index);

@@ -1,10 +1,28 @@
<<<<<<< HEAD
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
<<<<<<< HEAD
const logDuration = require("../models/duration");

<<<<<<< HEAD


// GET and POST will go here
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
// GET and POST will go here
router.get("/", repsCtrl.index);



function index(req, res) {
Log.find({}, function (err, workoutlog) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
Log.find({}, function (err, workoutlog) {
res.render("user/index");

@@ -1,3 +1,13 @@
<<<<<<< HEAD
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
<<<<<<< HEAD
const express = require("express");


// module.exports = {
// index,
// };

<<<<<<< HEAD
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Unnecessary semicolon.

Suggested change
<<<<<<< HEAD
}

@@ -1,3 +1,13 @@
<<<<<<< HEAD
const express = require('express');
const router = express.Router();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
const router = express.Router();
const durationCtrl = require("../controllers/duration");

@@ -1,3 +1,22 @@
<<<<<<< HEAD
// workoutlog data... connects to "user" page
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
// workoutlog data... connects to "user" page
const express = require("express");

@@ -1,3 +1,19 @@
<<<<<<< HEAD
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Strings must use doublequote.

Suggested change
<<<<<<< HEAD
const Log = require("../models/workoutlog");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant