use backend= instead of deprecated native_namespace= in nw.from_dict#381
Merged
elephaint merged 1 commit intoNixtla:mainfrom Jul 11, 2025
Merged
use backend= instead of deprecated native_namespace= in nw.from_dict#381elephaint merged 1 commit intoNixtla:mainfrom
backend= instead of deprecated native_namespace= in nw.from_dict#381elephaint merged 1 commit intoNixtla:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
Thanks, makes sense! Agree wrt stable API, but we need functions that are not in v1, so then it doesn't work, right? |
elephaint
approved these changes
Jul 11, 2025
Contributor
Author
|
thanks! yup, true - do you remember which non-v1 functions you need? (btw, we're close to having v2 🥳 ) |
1 task
Collaborator
I think it was the pivot function. Nice to see v2 coming! I want to start moving the rest of our libs to Narwhals too, but it'll be a big effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native_namespaceinnw.from_dictis deprecated since Narwhals 1.27, which is already your minimum versionhierarchicalforecast/settings.ini
Line 18 in 434c411
so is safe to do even for the oldest versions
For future reference, I'd also suggest using
narwhals.stable.v1to guard against API changes https://narwhals-dev.github.io/narwhals/backcompat/